Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

func create: persist --language choice #636

Closed
omerbensaadon opened this issue Nov 5, 2021 · 11 comments
Closed

func create: persist --language choice #636

omerbensaadon opened this issue Nov 5, 2021 · 11 comments
Assignees
@lkingland
Labels
kind/enhancement lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@omerbensaadon
Copy link

omerbensaadon commented Nov 5, 2021 •
edited
Loading

  • Give users the option to save the runtime as default (y/n)
  • Make sure to let them know where this is saved
  • Make sure the template always defaults to -c when not provided as a flag (-t)
@omerbensaadon omerbensaadon changed the title [placeholder issues] On first run of func create ask user if they would like to save their selected runtime as default [placeholder issues] On first run of func create (assuming -l flag is not provided) ask user if they would like to save their selected runtime as default Nov 5, 2021
@omerbensaadon omerbensaadon changed the title [placeholder issues] On first run of func create (assuming -l flag is not provided) ask user if they would like to save their selected runtime as default [placeholder issues] On first run of func create (assuming -l flag is not provided) ask user if they would like to save their selected runtime as default Nov 5, 2021
@lance
Copy link
Member

lance commented Nov 5, 2021

  • Make sure to let them know where this is saved

I don't think that's a great idea. I think the user should just be able to run func config global. See: #573 (comment)

@lkingland lkingland self-assigned this Nov 7, 2021
@lkingland
Copy link
Member

I will discuss this further with @lance this week, but the work I am doing on func invoke actually requires taking a bite out of the config situation: in particular opening the door to more conventional "config" settings, including git-like behavior of displaying a helpful message informing the user they need to choose a language, but can set a default via git config ... --global (exact syntax TBD)

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2022

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 6, 2022
@lance lance removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2022

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 9, 2022
@zroubalik
Copy link
Contributor

/remove-lifecycle stale

@knative-prow knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 9, 2022
@lkingland
Copy link
Member

To expand on this issue a bit, I was envisioning that the first time func is run, it will detect there is no user configuration, and the user will be prompted to run through a first-time setup, which is creating the global config (see #901). One of the questions asked of course being the user's preferred default language (if any).

@lance lance added this to the 1.0.0 Release milestone Jul 28, 2022
@lance lance added the MVP label Jul 28, 2022
@lance
Copy link
Member

lance commented Aug 9, 2022

Should be resolved in #901

@lkingland lkingland mentioned this issue Sep 20, 2022
Merged
@lance lance modified the milestones: 1.8.0 Release, 1.9.0 Release Oct 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2023

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 5, 2023
@zroubalik
Copy link
Contributor

/remove-lifecycle stale

@knative-prow knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 5, 2023
@lance lance modified the milestones: 1.9.0 Release, Release 1.10 Feb 14, 2023
@lance lance modified the milestones: Release 1.10, Release 1.11 May 16, 2023
@lance lance removed the MVP label May 16, 2023
@lkingland lkingland removed this from the Release 1.11 milestone Jul 18, 2023
@lkingland lkingland changed the title [placeholder issues] On first run of func create (assuming -l flag is not provided) ask user if they would like to save their selected runtime as default func create: persist --language choice Aug 23, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 8, 2024
@lkingland lkingland removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 22, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lkingland lkingland

Labels
kind/enhancement lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
Functions WG Roadmap
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lance @zroubalik @omerbensaadon @lkingland