Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Spring Boot to 2.7.7 #1502

Merged
merged 2 commits into from
Jan 18, 2023
Merged

Update Spring Boot to 2.7.7 #1502

merged 2 commits into from
Jan 18, 2023

Conversation

trisberg
Copy link
Member

  • also add function-template springboot.md doc

Signed-off-by: Thomas Risberg trisberg@pivotal.io

Changes

  • 🎁 Bumped Spring Boot version to 2.7.7
  • 🎁 Added instructions for building on ARM systems to README files
  • 🎁 Added new springboot.md doc to docs/function-templates

/kind documentation
/kind enhancement

Fixes #1501

Release Note

Updated `springboot` templates to use Spring Boot version 2.7.7

Docs

@trisberg
Update Spring Boot to 2.7.7
2994703 
- also add function-template springboot.md doc

Signed-off-by: Thomas Risberg <trisberg@pivotal.io>
@knative-prow knative-prow bot added kind/documentation kind/enhancement size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 17, 2023
@codecov
Copy link

codecov bot commented Jan 17, 2023 •
edited
Loading

Codecov Report

Base: 54.90% // Head: 63.37% // Increases project coverage by +8.46% 🎉

Coverage data is based on head (bff790c) compared to base (d3d3233).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1502      +/-   ##
==========================================
+ Coverage   54.90%   63.37%   +8.46%     
==========================================
  Files          72       75       +3     
  Lines       10597    10770     +173     
==========================================
+ Hits         5818     6825    +1007     
+ Misses       4352     3388     -964     
- Partials      427      557     +130
Flag Coverage Δ
integration-tests 53.25% <ø> (?)
unit-tests ?
unit-tests-macos-latest 53.29% <ø> (?)
unit-tests-ubuntu-latest 54.66% <ø> (?)
unit-tests-windows-latest 53.31% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/create.go 46.82% <0.00%> (-5.55%) ⬇️
openshift/openshift.go 5.40% <0.00%> (ø)
openshift/metadata.go 0.00% <0.00%> (ø)
docker/docker_client_nonlinux.go 0.00% <0.00%> (ø)
client.go 62.57% <0.00%> (+0.61%) ⬆️
docker/creds/credentials.go 73.06% <0.00%> (+1.34%) ⬆️
k8s/secrets.go 16.49% <0.00%> (+3.09%) ⬆️
k8s/configmaps.go 50.00% <0.00%> (+15.78%) ⬆️
k8s/client.go 88.46% <0.00%> (+23.07%) ⬆️
docker/docker_client.go 84.87% <0.00%> (+25.21%) ⬆️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@matejvasek
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2023
@matejvasek
Copy link
Contributor

/approve

@knative-prow
Copy link

knative-prow bot commented Jan 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek, trisberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2023
@knative-prow knative-prow bot merged commit 63aab77 into knative:main Jan 18, 2023
lance pushed a commit to lance/func that referenced this pull request Feb 15, 2023
@trisberg @lance
Update Spring Boot to 2.7.7 (knative#1502)
c5e21bb 
* Update Spring Boot to 2.7.7

- also add function-template springboot.md doc

Signed-off-by: Thomas Risberg <trisberg@pivotal.io>

* Fix lint errors

Signed-off-by: Thomas Risberg <trisberg@pivotal.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsimansk dsimansk Awaiting requested review from dsimansk

@navidshaikh navidshaikh Awaiting requested review from navidshaikh

Assignees

@matejvasek matejvasek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation kind/enhancement lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump Spring Boot to 2.7.7 and add function-template doc in springboot.md
2 participants
@trisberg @matejvasek