Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release 1.9] cherry pick template updates for Rust and SpringBoot #1663

Merged
merged 2 commits into from
Mar 31, 2023

Conversation

lance
Copy link
Member

@lance lance commented Mar 31, 2023

Cherry pick #1661 and #1658 to the release-1.9 branch.

Update Rust templates dependencies and UTs for Actix 4.x
Update springboot templates to Spring Boot 3.0.5

* Update springboot templates to Spring Boot 3.0.5

* Regenerated embedded file

* Regenerated embedded file one more time
@knative-prow knative-prow bot requested review from maximilien and rhuss March 31, 2023 20:19
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 31, 2023
@lance lance changed the title Release 1.9 [Release 1.9] cherry pick template updates for Rust and SpringBoot Mar 31, 2023
@lance
Copy link
Member Author

lance commented Mar 31, 2023

/cc @andrejusc @matejvasek

@knative-prow knative-prow bot requested a review from matejvasek March 31, 2023 20:20
@knative-prow
Copy link

knative-prow bot commented Mar 31, 2023

@lance: GitHub didn't allow me to request PR reviews from the following users: andrejusc.

Note that only knative members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @andrejusc @matejvasek

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +9.32 🎉

Comparison is base (1dd4eb6) 51.47% compared to head (22604a9) 60.80%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.9    #1663      +/-   ##
===============================================
+ Coverage        51.47%   60.80%   +9.32%     
===============================================
  Files               71       74       +3     
  Lines             9937    10074     +137     
===============================================
+ Hits              5115     6125    +1010     
+ Misses            4393     3392    -1001     
- Partials           429      557     +128     
Flag Coverage Δ
integration-tests 49.89% <0.00%> (?)
unit-tests-macos-latest 49.96% <0.00%> (?)
unit-tests-ubuntu-latest 51.45% <0.00%> (?)
unit-tests-windows-latest 50.02% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
s2i/builder.go 62.00% <100.00%> (+2.00%) ⬆️

... and 20 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@matejvasek
Copy link
Contributor

@andrejusc I am trying the templates but the produced images are not serving HTTP on 8080. Any idea what's wrong?

/hold

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 31, 2023
@matejvasek
Copy link
Contributor

Hmm old templates do the same.

@matejvasek
Copy link
Contributor

The HTTP works from within a container, but docker's -p forwarding is not working for me.

@matejvasek
Copy link
Contributor

curl: (56) Recv failure: Connection reset by peer

@matejvasek
Copy link
Contributor

I guess it's a bug in buildpacks.

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2023
@knative-prow
Copy link

knative-prow bot commented Mar 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matejvasek
Copy link
Contributor

The buildpacks are not exposing port on image for some reason.

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 31, 2023
@knative-prow knative-prow bot merged commit f1be444 into knative:release-1.9 Mar 31, 2023
@andrejusc
Copy link
Contributor

@lance - I thought there are some Rust image related build/test step inside those checks, but looking through them - only Rust Integration tests are there, but not image tests. I need to study how use case is done for Go case image inside checks (hopefully such is there) and then adopt for Rust, so we'll eliminate such potential breakage in future.
I'm not yet familiar deep enough with buildpacks to comment - will try to analyze more in upcoming days.

@andrejusc
Copy link
Contributor

@lance - issue is with code line (which I didn't change) and this binding to listen:
https://github.com/knative/func/blob/main/templates/rust/http/src/main.rs#L28
.bind(("127.0.0.1", port))?
If such replace to this:
.bind(("0.0.0.0", port))?
it should potentially work.

Could you give it a try? Otherwise - I'll review more on weekend to correct.

@lance
Copy link
Member Author

lance commented Mar 31, 2023

@andrejusc please work with @matejvasek on this next week. I will not be available until April 10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants