-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Release 1.9] cherry pick template updates for Rust and SpringBoot #1663
Conversation
* Update springboot templates to Spring Boot 3.0.5 * Regenerated embedded file * Regenerated embedded file one more time
@lance: GitHub didn't allow me to request PR reviews from the following users: andrejusc. Note that only knative members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## release-1.9 #1663 +/- ##
===============================================
+ Coverage 51.47% 60.80% +9.32%
===============================================
Files 71 74 +3
Lines 9937 10074 +137
===============================================
+ Hits 5115 6125 +1010
+ Misses 4393 3392 -1001
- Partials 429 557 +128
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 20 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
@andrejusc I am trying the templates but the produced images are not serving HTTP on 8080. Any idea what's wrong? /hold |
Hmm old templates do the same. |
The HTTP works from within a container, but docker's |
|
I guess it's a bug in buildpacks. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The buildpacks are not exposing port on image for some reason. /unhold |
@lance - I thought there are some Rust image related build/test step inside those checks, but looking through them - only Rust Integration tests are there, but not image tests. I need to study how use case is done for Go case image inside checks (hopefully such is there) and then adopt for Rust, so we'll eliminate such potential breakage in future. |
@lance - issue is with code line (which I didn't change) and this binding to listen: Could you give it a try? Otherwise - I'll review more on weekend to correct. |
@andrejusc please work with @matejvasek on this next week. I will not be available until April 10. |
Cherry pick #1661 and #1658 to the
release-1.9
branch.