Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Rust template project listen on 0.0.0.0 #1664

Merged
merged 1 commit into from
Apr 1, 2023
Merged

fix: Rust template project listen on 0.0.0.0 #1664

merged 1 commit into from
Apr 1, 2023

Conversation

matejvasek
Copy link
Contributor

Changes

  • 🐛 Rust template's Actix listen on 0.0.0.0
fix: rust template project listen on 0.0.0.0

@matejvasek
fix: actix listent on 0.0.0.0
8dcc12a 
Signed-off-by: Matej Vasek <mvasek@redhat.com>
@matejvasek matejvasek requested a review from lance March 31, 2023 22:31
@knative-prow knative-prow bot requested review from jrangelramos and rhuss March 31, 2023 22:31
@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 31, 2023
@matejvasek matejvasek requested review from jcrossley3 and removed request for rhuss March 31, 2023 22:31
@matejvasek
Copy link
Contributor Author

cc @andrejusc

@matejvasek
Copy link
Contributor Author

Without this containerized app cannot work at all.

@codecov
Copy link

codecov bot commented Mar 31, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: +8.10 🎉

Comparison is base (c6c0f7e) 54.82% compared to head (8dcc12a) 62.93%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1664      +/-   ##
==========================================
+ Coverage   54.82%   62.93%   +8.10%     
==========================================
  Files          92       93       +1     
  Lines       11937    11939       +2     
==========================================
+ Hits         6545     7514     +969     
+ Misses       4792     3747    -1045     
- Partials      600      678      +78
Flag Coverage Δ
e2e-test 38.85% <ø> (?)
e2e-test-oncluster 34.61% <ø> (ø)
e2e-test-oncluster-runtime 29.53% <ø> (?)
e2e-test-runtime-go 28.23% <ø> (?)
e2e-test-runtime-node 29.37% <ø> (?)
e2e-test-runtime-python 29.37% <ø> (?)
e2e-test-runtime-quarkus 29.50% <ø> (?)
e2e-test-runtime-springboot 28.35% <ø> (?)
e2e-test-runtime-typescript 29.50% <ø> (?)
integration-tests 49.37% <ø> (?)
unit-tests-macos-latest 48.18% <ø> (?)
unit-tests-ubuntu-latest 49.14% <ø> (ø)
unit-tests-windows-latest 48.12% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 27 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andrejusc
Copy link
Contributor

/approve
/lgtm

@knative-prow
Copy link

knative-prow bot commented Apr 1, 2023

@andrejusc: changing LGTM is restricted to collaborators

In response to this:

/approve
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow
Copy link

knative-prow bot commented Apr 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrejusc, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lance
Copy link
Member

lance commented Apr 1, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2023
@knative-prow knative-prow bot merged commit ae1b0c5 into knative:main Apr 1, 2023
lance pushed a commit to lance/func that referenced this pull request Apr 1, 2023
@matejvasek @lance
fix: actix listent on 0.0.0.0 (knative#1664)
0de7ad4 
Signed-off-by: Matej Vasek <mvasek@redhat.com>
knative-prow bot pushed a commit that referenced this pull request Apr 1, 2023
@lance @matejvasek
fix: actix listent on 0.0.0.0 (#1664) (#1665)
514a2ad 
Signed-off-by: Matej Vasek <mvasek@redhat.com>
Co-authored-by: Matej Vasek <mvasek@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance lance Awaiting requested review from lance

@jrangelramos jrangelramos Awaiting requested review from jrangelramos

@jcrossley3 jcrossley3 Awaiting requested review from jcrossley3

Assignees

@lance lance

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matejvasek @andrejusc @lance