-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: track go template sumfiles #1688
feat: track go template sumfiles #1688
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1688 +/- ##
==========================================
+ Coverage 62.84% 63.06% +0.21%
==========================================
Files 93 93
Lines 11967 11967
==========================================
+ Hits 7521 7547 +26
+ Misses 3757 3734 -23
+ Partials 689 686 -3
Flags with carried forward coverage won't be shown. Click here to find out more. see 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In order for Scaffolding to correctly associate the dependencies of the "embedded" function, we actually do need to track the initial sumfiles for the source function template. This change should have no effect on "nonscaffolded" functions; and we probably should have been doing this anyway.
/kind cleanup