Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: track go template sumfiles #1688

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

lkingland
Copy link
Member

  • 🧹 enable tracking of Go sumfiles in templates

In order for Scaffolding to correctly associate the dependencies of the "embedded" function, we actually do need to track the initial sumfiles for the source function template. This change should have no effect on "nonscaffolded" functions; and we probably should have been doing this anyway.

/kind cleanup

@knative-prow knative-prow bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 25, 2023
@knative-prow knative-prow bot requested review from maximilien and rhuss April 25, 2023 00:51
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 25, 2023
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.21 🎉

Comparison is base (506cb71) 62.84% compared to head (8dc3944) 63.06%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1688      +/-   ##
==========================================
+ Coverage   62.84%   63.06%   +0.21%     
==========================================
  Files          93       93              
  Lines       11967    11967              
==========================================
+ Hits         7521     7547      +26     
+ Misses       3757     3734      -23     
+ Partials      689      686       -3     
Flag Coverage Δ
e2e-test 38.86% <ø> (ø)
e2e-test-oncluster 34.74% <ø> (+0.10%) ⬆️
e2e-test-oncluster-runtime 29.56% <ø> (?)
e2e-test-runtime-go 28.16% <ø> (?)
e2e-test-runtime-node 29.40% <ø> (?)
e2e-test-runtime-python 29.40% <ø> (?)
e2e-test-runtime-quarkus 29.53% <ø> (?)
e2e-test-runtime-springboot 28.42% <ø> (?)
e2e-test-runtime-typescript 29.53% <ø> (?)
integration-tests 50.07% <ø> (+0.07%) ⬆️
unit-tests-macos-latest 48.81% <ø> (-0.03%) ⬇️
unit-tests-ubuntu-latest 49.76% <ø> (+0.02%) ⬆️
unit-tests-windows-latest 48.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lkingland lkingland marked this pull request as ready for review April 25, 2023 06:37
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 25, 2023
@knative-prow knative-prow bot requested review from maximilien and rhuss April 25, 2023 06:37
@lkingland lkingland mentioned this pull request Apr 25, 2023
14 tasks
@matejvasek
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2023
@knative-prow
Copy link

knative-prow bot commented Apr 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lkingland,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 5cf4828 into knative:main Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants