-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: host-based scaffolded function runner #1733
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
72a4710
to
eaf548f
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1733 +/- ##
==========================================
+ Coverage 62.38% 62.62% +0.24%
==========================================
Files 98 99 +1
Lines 13066 13207 +141
==========================================
+ Hits 8151 8271 +120
- Misses 4130 4143 +13
- Partials 785 793 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
eaf548f
to
7a9fb28
Compare
7a9fb28
to
b05b98a
Compare
97312c4
to
dc4c4e7
Compare
dc4c4e7
to
fa317ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just a few minor comments.
Thanks for the review @lance. Your improvements to the PR have been made |
/lgtm |
/kind enhancement