Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump faas-js-runtime and cloudevents for node & TS #1873

Merged
merged 2 commits into from
Jul 19, 2023
Merged

chore: bump faas-js-runtime and cloudevents for node & TS #1873

merged 2 commits into from
Jul 19, 2023

Conversation

lance
Copy link
Member

@lance lance commented Jul 17, 2023

Changes

The Node.js and TypeScript templates have been bumped to the latest versions of faas-js-runtime (2.2.2) and CloudEvents (7.0.1).

There is an issue with the expectType test for TypeScript CloudEvent functions which I can't quite figure out, but the type test is not critical and does not do anything to validate other than whether the function signature is what's expected by faas-js-runtime, and in this case, I think type exported type for faas-js-runtime may actually be the issue here.

/kind chore

Release Note

* bumps faas-js-runtime to version 2.2.2
* bumps cloudevents to version 7.0.1

/cc @matejvasek

@knative-prow knative-prow bot requested a review from matejvasek July 17, 2023 21:12
@knative-prow knative-prow bot added kind/chore size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 17, 2023
@codecov
Copy link

codecov bot commented Jul 17, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: +2.48 🎉

Comparison is base (a9e5281) 60.45% compared to head (79aacb8) 62.93%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1873      +/-   ##
==========================================
+ Coverage   60.45%   62.93%   +2.48%     
==========================================
  Files         106      107       +1     
  Lines       13727    13729       +2     
==========================================
+ Hits         8298     8641     +343     
+ Misses       4608     4223     -385     
- Partials      821      865      +44
Flag Coverage Δ
e2e-test 35.57% <ø> (ø)
e2e-test-oncluster 30.70% <ø> (?)
e2e-test-oncluster-runtime 25.63% <ø> (?)
e2e-test-runtime-go 25.98% <ø> (?)
e2e-test-runtime-node 26.99% <ø> (?)
e2e-test-runtime-python 26.99% <ø> (?)
e2e-test-runtime-quarkus 27.10% <ø> (?)
e2e-test-runtime-springboot 26.12% <ø> (?)
e2e-test-runtime-typescript 27.10% <ø> (?)
integration-tests 51.51% <ø> (+2.15%) ⬆️
unit-tests-macos-latest 49.28% <ø> (?)
unit-tests-ubuntu-latest 50.06% <ø> (?)
unit-tests-windows-latest 49.28% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 18, 2023
@matejvasek
Copy link
Contributor

/test unit-tests

1 similar comment
@matejvasek
Copy link
Contributor

/test unit-tests

@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 18, 2023
@lance
Copy link
Member Author

lance commented Jul 18, 2023

/override unit-tests_func_main

@knative-prow
Copy link

knative-prow bot commented Jul 18, 2023

@lance: Overrode contexts on behalf of lance: unit-tests_func_main

In response to this:

/override unit-tests_func_main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@matejvasek
Copy link
Contributor

/hold

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 18, 2023
@matejvasek
Copy link
Contributor

matejvasek commented Jul 18, 2023 •
edited
Loading

@lance it looks like there is a double definition of types.
There is node_modules/faas-js-runtime/node_modules/cloudevents/dist/event/cloudevent and node_modules/cloudevents/dist/event/cloudevent. They are not compatible that's why expectType<>() is not working I believe. But it is weird since the definitions are identical.

@matejvasek
Copy link
Contributor

@lance what node_modules/faas-js-runtime/node_modules even is? I don't know much about node but having node_modules in module seems fishy to me.

@matejvasek
Copy link
Contributor

When I delete node_modules/faas-js-runtime/node_modules the type-check does work.

@matejvasek
Copy link
Contributor

It is weird nonetheless, I thought that TS is structurally type (not nominally) so I would expect even double definition to work.

@matejvasek
Copy link
Contributor

@lance it looks like there is a double definition of types. There is node_modules/faas-js-runtime/node_modules/cloudevents/dist/event/cloudevent and node_modules/cloudevents/dist/event/cloudevent. They are not compatible that's why expectType<>() is not working I believe. But it is weird since the definitions are identical.

@lholmquist any idea why this would be happening?

@lance
chore: bump faas-js-runtime and cloudevents for node & TS
83e6c58 
The Node.js and TypeScript templates have been bumped to the latest
versions of faas-js-runtime (2.2.2) and CloudEvents (7.0.1).

There is an issue with the `expectType` test for TypeScript CloudEvent
functions which I can't quite figure out, but the type test is not
critical and does not do anything to validate other than whether the
function signature is what's expected by faas-js-runtime, and in this
case, I think type exported type for faas-js-runtime may actually be the
issue here.

Signed-off-by: Lance Ball <lball@redhat.com>
@lance
chore: pin all github actions to go 1.20.2
79aacb8 
There was a change in how go parses URLs in versions higher than 1.20.2
(likely 1.20.6 and up) which breaks the Docker API's handling of daemon
URIs. This fix pins the Go version at a version known to work with the
existing Docker API and `func` implementation.

Signed-off-by: Lance Ball <lball@redhat.com>
@lance lance mentioned this pull request Jul 19, 2023
Merged
@matejvasek
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2023
@knative-prow
Copy link

knative-prow bot commented Jul 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matejvasek
Copy link
Contributor

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 19, 2023
@knative-prow knative-prow bot merged commit 36489f3 into knative:main Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejvasek matejvasek Awaiting requested review from matejvasek

@lkingland lkingland Awaiting requested review from lkingland

Assignees

@matejvasek matejvasek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/chore lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lance @matejvasek @knative-prow-robot