templates: Node.js event template to return event #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Converting to draft so that I can also include a fix for #194 |
This commit modifies the Node.js template so that it returns a CloudEvent. The tests are also modified to test for CloudEvent attributes and headers. Additionally the faas-js-runtime bump reverses the parameters for the function. Fixes: knative#190 Fixes: knative#194 Signed-off-by: Lance Ball <lball@redhat.com>
lance
force-pushed
the
190-nodejs-ce-responses
branch
from
9edad24 to
6932ef2
Compare
Contributor
Author
|
@boson-project/core PTAL |
zroubalik
reviewed
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit modifies the Node.js template so that it returns a CloudEvent. The
tests are also modified to test for CloudEvent attributes and headers. Additionally
the faas-js-runtime bump reverses the parameters for the function.
Fixes: #190
Fixes: #194
Signed-off-by: Lance Ball lball@redhat.com