Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invoke instanced CE function's handle withNew() #2119

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Invoke instanced CE function's handle withNew() #2119

merged 2 commits into from
Jan 16, 2024

Conversation

matzew
Copy link
Member

@matzew matzew commented Jan 16, 2024

Changes

  • 🧹 Update file to have it compile

/kind

Fixes #

Release Note

Docs

@knative-prow Knative Prow
Copy link

knative-prow bot commented Jan 16, 2024

@matzew: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

  • 🧹 Update file to have it compile

/kind

Fixes #

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot requested review from dsimansk and maximilien January 16, 2024 10:57
@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 16, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8ecf77d) 64.24% compared to head (7be4ad3) 61.53%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2119      +/-   ##
==========================================
- Coverage   64.24%   61.53%   -2.72%     
==========================================
  Files         108      106       -2     
  Lines       13888    13879       -9     
==========================================
- Hits         8922     8540     -382     
- Misses       4098     4470     +372     
- Partials      868      869       +1
Flag Coverage Δ
e2e-test ?
e2e-test-oncluster 30.52% <ø> (+<0.01%) ⬆️
e2e-test-oncluster-runtime 26.56% <ø> (?)
e2e-test-runtime-go 25.54% <ø> (?)
integration-tests 51.88% <ø> (+1.99%) ⬆️
unit-tests-macos-latest ?
unit-tests-ubuntu-latest 49.59% <ø> (ø)
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jan 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2024
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 16, 2024
matzew added 2 commits January 16, 2024 15:31
@matzew
💄 Adding New() to make the file compile
92371ab 
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@matzew
Checkin stuff to make test in IDE pass
7be4ad3 
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@matzew matzew force-pushed the add_new_invocation branch from 52fe32d to 7be4ad3 Compare January 16, 2024 14:32
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jan 16, 2024

New changes are detected. LGTM label has been removed.

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2024
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 16, 2024
@lkingland lkingland added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2024
@knative-prow knative-prow bot merged commit e4430de into knative:main Jan 16, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkingland lkingland lkingland approved these changes

@dsimansk dsimansk Awaiting requested review from dsimansk

@maximilien maximilien Awaiting requested review from maximilien

Assignees

@lkingland lkingland

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matzew @lkingland @knative-prow-robot