corrected error msg

[swastik959]

Changes

/kind bug

Fixes #2257

Release Note

Docs

[knative-prow]

Hi @swastik959. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 65.68%. Comparing base (2ac73da) to head (4247e8f).
Report is 9 commits behind head on main.

Files	Patch %	Lines
pkg/knative/deployer.go	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2372      +/-   ##
==========================================
+ Coverage   60.20%   65.68%   +5.48%     
==========================================
  Files         128      128              
  Lines       14895    11537    -3358     
==========================================
- Hits         8967     7578    -1389     
+ Misses       5008     3002    -2006     
- Partials      920      957      +37     

Flag	Coverage Δ
e2e-test	37.98% <0.00%> (-0.02%)	⬇️
e2e-test-oncluster	31.18% <0.00%> (-0.01%)	⬇️
e2e-test-oncluster-runtime	27.11% <0.00%> (?)
e2e-test-runtime-go	26.03% <0.00%> (?)
e2e-test-runtime-node	26.99% <0.00%> (?)
e2e-test-runtime-python	26.99% <0.00%> (?)
e2e-test-runtime-quarkus	27.09% <0.00%> (?)
e2e-test-runtime-rust	26.10% <0.00%> (?)
e2e-test-runtime-springboot	26.12% <0.00%> (?)
e2e-test-runtime-typescript	27.08% <0.00%> (?)
integration-tests	51.27% <0.00%> (+2.47%)	⬆️
unit-tests	49.27% <0.00%> (?)
unit-tests-macos-latest	?
unit-tests-ubuntu-latest	?
unit-tests-windows-latest	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[matejvasek]

@swastik959 you need to fix that linter error.

[swastik959]

@matejvasek should I remove the fmt.print for all the conditions ?

[matejvasek]

@swastik959 the fmt.Sprint() is unnecessary at line 969 since there is no formatting, you can use plain string there.

[matejvasek]

/approve
/lgtm

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek, swastik959

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[matejvasek]

/ok-to-test