-
Notifications
You must be signed in to change notification settings - Fork 176
Feature: Add remote build and workflow dispatch options to CI workflows. #3128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add remote build and workflow dispatch options to CI workflows. #3128
Conversation
|
Skipping CI for Draft Pull Request. |
edad0e7 to
2b2cc43
Compare
48ac762 to
c2000cd
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3128 +/- ##
==========================================
- Coverage 55.05% 55.02% -0.03%
==========================================
Files 170 170
Lines 19816 19851 +35
==========================================
+ Hits 10910 10924 +14
- Misses 7840 7856 +16
- Partials 1066 1071 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
82faa71 to
6d6a8bd
Compare
6d6a8bd to
cd38ebc
Compare
0219c2f to
57da840
Compare
57da840 to
9cd85ce
Compare
9cd85ce to
c940f42
Compare
a150c48 to
fd23887
Compare
fd23887 to
37dfa45
Compare
|
/cc @gauron99 @lkingland |
gauron99
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. This looks good to me, just some linter errors a one comment
Add support for building functions on Tekton-enabled clusters through the new --remote flag, which modifies the deployment workflow to use remote builds and updates the workflow name accordingly. Add workflow_dispatch trigger support via --workflow-dispatch flag to enable manual workflow execution from terminal with GitHub cli or via GitHub UI. Update func CLI GitHub Action from gauron99 to the official functions-dev/action source with version bump to knative-v1.20.1. Issue knative#3256 Signed-off-by: Stanislav Jakuschevskij <sjakusch@redhat.com>
37dfa45 to
20af6c9
Compare
gauron99
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! thanks!
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99, twoGiants The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
--remoteflag for building functions on Tekton-enabled clusters--workflow-dispatchflag to enable manual workflow execution from GitHub UI or CLIfunctions-dev/actionsource (knative-v1.20.1)/kind enhancement
Relates to #3256
Release Note
Docs