Skip to content

Conversation

@twoGiants
Copy link
Contributor

@twoGiants twoGiants commented Oct 22, 2025

Changes

  • 🎁 Add --remote flag for building functions on Tekton-enabled clusters
  • 🎁 Add --workflow-dispatch flag to enable manual workflow execution from GitHub UI or CLI
  • 🧹 Update func CLI GitHub Action to official functions-dev/action source (knative-v1.20.1)

/kind enhancement

Relates to #3256

Release Note

Add `--remote` flag to `func config ci` to build functions on a Tekton enabled cluster and `--workflow-dispatch` to trigger workflows manually via the GitHub CLI or UI.

Docs


@knative-prow
Copy link

knative-prow bot commented Oct 22, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/enhancement labels Oct 22, 2025
@knative-prow knative-prow bot requested review from jrangelramos and nainaz October 22, 2025 12:26
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 22, 2025
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 22, 2025
@twoGiants twoGiants force-pushed the issue-744-generate-github-actions-workflow branch 2 times, most recently from edad0e7 to 2b2cc43 Compare October 24, 2025 16:48
@knative-prow knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 24, 2025
@twoGiants twoGiants force-pushed the issue-744-generate-github-actions-workflow branch from 48ac762 to c2000cd Compare November 7, 2025 12:16
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 7, 2025
@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

❌ Patch coverage is 82.35294% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.02%. Comparing base (e7a440b) to head (20af6c9).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/ci/workflow.go 70.00% 5 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3128      +/-   ##
==========================================
- Coverage   55.05%   55.02%   -0.03%     
==========================================
  Files         170      170              
  Lines       19816    19851      +35     
==========================================
+ Hits        10910    10924      +14     
- Misses       7840     7856      +16     
- Partials     1066     1071       +5     
Flag Coverage Δ
e2e 39.59% <0.00%> (-0.09%) ⬇️
e2e go 35.60% <0.00%> (-0.10%) ⬇️
e2e node 31.13% <0.00%> (-0.07%) ⬇️
e2e python 35.27% <0.00%> (-0.17%) ⬇️
e2e quarkus 31.28% <0.00%> (-0.07%) ⬇️
e2e rust 30.72% <0.00%> (-0.09%) ⬇️
e2e springboot 30.77% <0.00%> (-0.07%) ⬇️
e2e typescript 31.25% <0.00%> (-0.07%) ⬇️
integration 17.46% <0.00%> (-0.06%) ⬇️
unit macos-14 44.96% <84.09%> (+0.06%) ⬆️
unit macos-latest 44.96% <84.09%> (+0.06%) ⬆️
unit ubuntu-24.04-arm 45.07% <82.35%> (+0.05%) ⬆️
unit ubuntu-latest 45.86% <84.09%> (+0.06%) ⬆️
unit windows-latest 44.98% <84.09%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 12, 2025
@twoGiants twoGiants force-pushed the issue-744-generate-github-actions-workflow branch 4 times, most recently from 82faa71 to 6d6a8bd Compare December 2, 2025 08:29
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 2, 2025
@twoGiants twoGiants force-pushed the issue-744-generate-github-actions-workflow branch from 6d6a8bd to cd38ebc Compare December 3, 2025 17:01
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 6, 2025
@twoGiants twoGiants force-pushed the issue-744-generate-github-actions-workflow branch 4 times, most recently from 0219c2f to 57da840 Compare December 13, 2025 10:41
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 13, 2025
@twoGiants twoGiants force-pushed the issue-744-generate-github-actions-workflow branch from 57da840 to 9cd85ce Compare December 15, 2025 09:47
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 15, 2025
@twoGiants twoGiants force-pushed the issue-744-generate-github-actions-workflow branch from 9cd85ce to c940f42 Compare December 15, 2025 10:20
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 15, 2025
@twoGiants twoGiants force-pushed the issue-744-generate-github-actions-workflow branch 2 times, most recently from a150c48 to fd23887 Compare December 19, 2025 11:12
@twoGiants twoGiants changed the title 🚧 [WIP] 🚧 Generate GitHub actions workflow. 👷 🏗️ Feature: Add remote build and workflow dispatch options to CI workflows. Dec 19, 2025
@twoGiants twoGiants force-pushed the issue-744-generate-github-actions-workflow branch from fd23887 to 37dfa45 Compare December 19, 2025 11:22
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 19, 2025
@twoGiants twoGiants marked this pull request as ready for review December 19, 2025 11:22
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 19, 2025
@knative-prow knative-prow bot requested a review from dsimansk December 19, 2025 11:22
@twoGiants
Copy link
Contributor Author

/cc @gauron99 @lkingland

@knative-prow knative-prow bot requested review from gauron99 and lkingland December 19, 2025 11:23
Copy link
Contributor

@gauron99 gauron99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. This looks good to me, just some linter errors a one comment

Add support for building functions on Tekton-enabled clusters
through the new --remote flag, which modifies the deployment
workflow to use remote builds and updates the workflow name
accordingly.

Add workflow_dispatch trigger support via --workflow-dispatch
flag to enable manual workflow execution from terminal with
GitHub cli or via GitHub UI.

Update func CLI GitHub Action from gauron99 to the official
functions-dev/action source with version bump to knative-v1.20.1.

Issue knative#3256

Signed-off-by: Stanislav Jakuschevskij <sjakusch@redhat.com>
@twoGiants twoGiants force-pushed the issue-744-generate-github-actions-workflow branch from 37dfa45 to 20af6c9 Compare December 19, 2025 12:27
Copy link
Contributor

@gauron99 gauron99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! thanks!
/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2025
@knative-prow
Copy link

knative-prow bot commented Dec 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, twoGiants

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2025
@knative-prow knative-prow bot merged commit cf46238 into knative:main Dec 19, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants