Skip to content

Conversation

@gauron99
Copy link
Contributor

@gauron99 gauron99 commented Nov 10, 2025

Springboot template is failing for pack because of our updated custom builder for buildpacks build. This change makes it so the tests pass and dont hold up any PRs.

Im not 100% how the springboot is running but perhaps something changed externally and its now trying to run with java instead of native build (again not sure how this works) and therefore the build is failing without this change

@knative-prow
Copy link

knative-prow bot commented Nov 10, 2025

@gauron99: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

Details

In response to this:

Changes

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow
Copy link

knative-prow bot commented Nov 10, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 10, 2025
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 10, 2025
@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.15%. Comparing base (deff3bf) to head (58edb9c).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3181      +/-   ##
==========================================
+ Coverage   63.12%   63.15%   +0.02%     
==========================================
  Files         150      150              
  Lines       13227    13501     +274     
==========================================
+ Hits         8350     8527     +177     
- Misses       3916     3970      +54     
- Partials      961     1004      +43     
Flag Coverage Δ
e2e-tests 42.33% <ø> (+0.90%) ⬆️
integration-tests 57.60% <ø> (+0.97%) ⬆️
unit-tests 49.47% <ø> (-0.74%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gauron99 gauron99 changed the title springboot envvar fix: Springboot template update to make test pass Nov 11, 2025
@gauron99 gauron99 marked this pull request as ready for review November 11, 2025 10:26
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 11, 2025
@gauron99 gauron99 requested review from lkingland and matejvasek and removed request for dsimansk and jrangelramos November 11, 2025 10:26
@matejvasek
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2025
@knative-prow
Copy link

knative-prow bot commented Nov 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [gauron99,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit b785e68 into knative:main Nov 11, 2025
46 of 47 checks passed
@gauron99 gauron99 deleted the push-wstpxtxvxznk branch November 18, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants