-
Notifications
You must be signed in to change notification settings - Fork 174
fix: Springboot template update to make test pass #3181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@gauron99: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Skipping CI for Draft Pull Request. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3181 +/- ##
==========================================
+ Coverage 63.12% 63.15% +0.02%
==========================================
Files 150 150
Lines 13227 13501 +274
==========================================
+ Hits 8350 8527 +177
- Misses 3916 3970 +54
- Partials 961 1004 +43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4979ed6 to
58edb9c
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Springboot template is failing for pack because of our updated custom builder for buildpacks build. This change makes it so the tests pass and dont hold up any PRs.
Im not 100% how the springboot is running but perhaps something changed externally and its now trying to run with java instead of native build (again not sure how this works) and therefore the build is failing without this change