Skip to content

fix(tekton): ensure PAC Repository updates labels and annotations #3258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knative-prow merged 2 commits into from
Dec 5, 2025
Merged

fix(tekton): ensure PAC Repository updates labels and annotations #3258

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87efdfc
compare labels
intojhanurag Nov 29, 2025
a79c8dd
linting issue
intojhanurag Nov 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions pkg/pipelines/tekton/resources_pac.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,13 +77,19 @@ func ensurePACRepositoryExists(ctx context.Context, f fn.Function, namespace str
repoNotFound = true
}

// TODO we should also compare labels and annotations
if repoNotFound || !equality.Semantic.DeepDerivative(existingRepo.Spec, repo.Spec) {
// Decide whether create or update
needsUpdate := repoNotFound ||
!equality.Semantic.DeepDerivative(existingRepo.Spec, repo.Spec) ||
!equality.Semantic.DeepEqual(existingRepo.Labels, repo.Labels) ||
!equality.Semantic.DeepEqual(existingRepo.Annotations, repo.Annotations)

if needsUpdate {
if repoNotFound {
_, err = client.Repositories(namespace).Create(ctx, &repo, metav1.CreateOptions{})
} else {
_, err = client.Repositories(namespace).Update(ctx, &repo, metav1.UpdateOptions{})
existingRepo.Spec = repo.Spec
existingRepo.Labels = repo.Labels
existingRepo.Annotations = repo.Annotations
_, err = client.Repositories(namespace).Update(ctx, existingRepo, metav1.UpdateOptions{})
}
if err != nil {
return err
Expand Down
Loading