Skip to content

Conversation

@twoGiants
Copy link
Contributor

@twoGiants twoGiants commented Dec 3, 2025

Changes

  • 🎁 Add func config ci command skeleton to prepare for GitHub Actions workflow generation
  • 🎁 Add configuration management for CI workflow paths and names
  • 🎁 Protect new functionality behind FUNC_ENABLE_CI_CONFIG feature flag

/kind enhancement

Relates to #3256

Release Note


Docs


@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 3, 2025
@twoGiants
Copy link
Contributor Author

twoGiants commented Dec 3, 2025

/cc @matejvasek @gauron99 @creydr

@knative-prow knative-prow bot requested review from gauron99 and matejvasek December 3, 2025 13:59
@twoGiants twoGiants force-pushed the issue-744-command-skeleton branch from c63913f to 77e77e3 Compare December 3, 2025 14:12
@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

❌ Patch coverage is 67.30769% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.58%. Comparing base (90c8da5) to head (baab41d).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
cmd/ci/config.go 0.00% 13 Missing ⚠️
cmd/testing/factory.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3266      +/-   ##
==========================================
+ Coverage   54.54%   54.58%   +0.03%     
==========================================
  Files         164      166       +2     
  Lines       19234    19280      +46     
==========================================
+ Hits        10492    10524      +32     
- Misses       7702     7714      +12     
- Partials     1040     1042       +2     
Flag Coverage Δ
e2e 39.93% <38.09%> (-0.01%) ⬇️
e2e go 35.88% <38.09%> (+<0.01%) ⬆️
e2e node 31.27% <38.09%> (+0.02%) ⬆️
e2e python 35.52% <38.09%> (+<0.01%) ⬆️
e2e quarkus 31.42% <38.09%> (+0.02%) ⬆️
e2e rust 30.79% <38.09%> (-0.03%) ⬇️
e2e springboot 30.82% <38.09%> (-0.03%) ⬇️
e2e typescript 31.38% <38.09%> (+0.02%) ⬆️
integration 17.83% <0.00%> (-0.09%) ⬇️
unit macos-14 44.47% <65.21%> (+0.10%) ⬆️
unit macos-latest 44.47% <65.21%> (+0.10%) ⬆️
unit ubuntu-24.04-arm 44.67% <67.30%> (+0.10%) ⬆️
unit ubuntu-latest 45.40% <65.21%> (+0.10%) ⬆️
unit windows-latest 44.49% <65.21%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@twoGiants twoGiants force-pushed the issue-744-command-skeleton branch from 77e77e3 to 4ce76a1 Compare December 3, 2025 14:28
@gauron99
Copy link
Contributor

gauron99 commented Dec 3, 2025

/lgtm
/approve
/hold for potential other reviews

@knative-prow knative-prow bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 3, 2025
Introduces a new 'func config ci' subcommand to prepare for
GitHub workflow generation capabilities. The command structure
includes configuration management for workflow paths and names,
protected behind the FUNC_ENABLE_CI_CONFIG feature flag.

Previously, there was no way to configure CI/CD workflows for
functions. This change adds the foundational command structure
that will eventually generate GitHub Actions workflow files for
automated function deployment.

The implementation is currently incomplete (returns "not
implemented") and serves as scaffolding for future work.

Issue knative#3256

Signed-off-by: Stanislav Jakuschevskij <sjakusch@redhat.com>
@twoGiants twoGiants force-pushed the issue-744-command-skeleton branch from 4ce76a1 to baab41d Compare December 3, 2025 16:50
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2025
@matejvasek
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2025
@knative-prow
Copy link

knative-prow bot commented Dec 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, matejvasek, twoGiants

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [gauron99,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matejvasek
Copy link
Contributor

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2025
@knative-prow knative-prow bot merged commit 859ef43 into knative:main Dec 5, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants