Skip to content

Fix architecture variable in build command #3282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knative-prow merged 1 commit into from
Dec 9, 2025
Merged

Fix architecture variable in build command #3282

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/functions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@
if: always()
uses: actions/upload-artifact@v4
with:
name: cluster-logs-${{ matrix.os }}-podman

Check failure on line 284 in .github/workflows/functions.yaml

View workflow job for this annotation

GitHub Actions / actionlint

[actionlint] .github/workflows/functions.yaml#L284 

property "os" is not defined in object type {} [expression]
Raw output 
e:.github/workflows/functions.yaml:284:34: property "os" is not defined in object type {} [expression]
path: ./cluster_log.txt
retention-days: 7

Expand Down Expand Up @@ -438,7 +438,7 @@
- name: Build and push
run: |
for a in amd64 arm64 ppc64le s390x; do
CGO_ENABLED=0 go build -o "func-util-$a" -trimpath -ldflags '-w -s' ./cmd/func-util
CGO_ENABLED=0 GOARCH="${a}" go build -o "func-util-$a" -trimpath -ldflags '-w -s' ./cmd/func-util
done
docker buildx create --name multiarch --driver docker-container --use
docker buildx build . -f Dockerfile.utils \
Expand Down
Loading