Feature: Implement GitHub workflow generation for func config ci.
#3295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
the
size/XL
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3295 +/- ##
==========================================
+ Coverage 54.74% 54.91% +0.17%
==========================================
Files 168 170 +2
Lines 19605 19742 +137
==========================================
+ Hits 10732 10842 +110
- Misses 7807 7831 +24
- Partials 1066 1069 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
twoGiants
force-pushed
the
issue-744-basic-workflow
branch
2 times, most recently
from
595194c to
0ef564a
Compare
This change adds GitHub Actions workflow generation for deploying functions. The workflow includes checkout, Kubernetes context setup via kubeconfig, func CLI installation, and deployment with registry configuration. The command is feature-flagged (FUNC_ENABLE_CI_CONFIG) to allow gradual rollout. Users can customize workflow parameters: - Branch trigger (default: main) - Kubeconfig secret name (default: KUBECONFIG) - Registry URL variable (default: REGISTRY_URL) - Workflow name (default: Func Deploy) Implementation includes comprehensive test coverage with both unit tests (mocked components) and integration tests (real filesystem operations). Also extracts MockLoaderSaver to cmd/common for reusability across test suites. Issue knative#3256 Signed-off-by: Stanislav Jakuschevskij <sjakusch@redhat.com>
twoGiants
force-pushed
the
issue-744-basic-workflow
branch
from
0ef564a to
79d4bae
Compare
Contributor
Author
knative-prow
bot
requested review from
creydr,
gauron99,
lkingland and
matejvasek
lkingland
approved these changes
Dec 15, 2025
Member
lkingland
left a comment
lkingland
left a comment
There was a problem hiding this comment.
Definitely going in a nice direction!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland, twoGiants The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
Member
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
func config cicommand (previously skeleton-only)MockLoaderSavertocmd/commonfor test code reusability/kind enhancement
Part of #3256
Release Note
Docs