Feature: Add registry login to CI workflows. #3297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub workflows generated by 'func config ci' previously lacked registry authentication. Now a registry login step was added. Add new flags for registry authentication and runner configuration: - --use-registry-login: enable/disable registry login step (default: true) - --registry-login-url-variable-name: customize registry URL variable (default: REGISTRY_LOGIN_URL) - --registry-user-variable-name: customize username variable (default: REGISTRY_USERNAME) - --registry-pass-secret-name: customize password secret (default: REGISTRY_PASSWORD) - --self-hosted-runner: use self-hosted instead of ubuntu-latest runners (default: false) Workflow generation logic is refactored into helper functions for better maintainability. More logic will be added to this functions in follow up PRs. Issue knative#3256 Signed-off-by: Stanislav Jakuschevskij <sjakusch@redhat.com>
knative-prow
bot
added
kind/enhancement
size/L
Contributor
Author
knative-prow
bot
requested review from
gauron99,
jrangelramos,
lkingland and
matejvasek
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3297 +/- ##
==========================================
+ Coverage 54.92% 54.98% +0.06%
==========================================
Files 170 170
Lines 19744 19824 +80
==========================================
+ Hits 10844 10900 +56
- Misses 7832 7852 +20
- Partials 1068 1072 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gauron99
approved these changes
Dec 17, 2025
Contributor
gauron99
left a comment
gauron99
left a comment
There was a problem hiding this comment.
/lgtm
just left some non-blocking comments. Thanks!
Comment on lines
+41
to
+45
| steps = createCheckoutStep(steps) | ||
| steps = createK8ContextStep(conf, steps) | ||
| steps = createRegistryLoginStep(conf, steps) | ||
| steps = createFuncCLIInstallStep(steps) | ||
| steps = createFuncDeployStep(conf, steps) |
Contributor
There was a problem hiding this comment.
I like these one line steps, much cleaner :)
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99, twoGiants The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
--use-registry-loginflag to enable/disable registry login step in generated workflow (default: true)--self-hosted-runnerflag to use self-hosted runners instead of ubuntu-latest (default: false)--registry-login-url-variable-nameflag to customize the registry URL variable name in the workflow (default: REGISTRY_LOGIN_URL)--registry-user-variable-nameflag to customize the registry username variable name in the workflow (default: REGISTRY_USERNAME)--registry-pass-secret-nameflag to customize the registry password secret name in the workflow (default: REGISTRY_PASSWORD)docker/login-action@v3in generated workflows/kind enhancement
Relates to #3256
Release Note
Docs