Clean up auth for host builder

[matejvasek]

Changes

• Removed credentials propagation via Go's context since we already pass credentials in a different way.
• Fixed issue where user might be prompted for credentials even if they are set via environment variables.
• The FUNC_[USERNAME|PASSWORD] environment variables now work also for the pushers other that the host pusher.

fix: hidden flags username/password (and affiliated envvars) now work also for s2i and pack builder

[codecov]

Codecov Report

❌ Patch coverage is 69.56522% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.92%. Comparing base (4ef5654) to head (6c906f7).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
cmd/client.go	50.00%	6 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3298   +/-   ##
=======================================
  Coverage   54.92%   54.92%           
=======================================
  Files         170      170           
  Lines       19744    19736    -8     
=======================================
- Hits        10844    10840    -4     
+ Misses       7832     7831    -1     
+ Partials     1068     1065    -3     

Flag	Coverage Δ
e2e	39.88% <61.90%> (+<0.01%)	⬆️
e2e go	35.87% <61.90%> (+<0.01%)	⬆️
e2e node	31.36% <28.57%> (+<0.01%)	⬆️
e2e python	35.52% <61.90%> (+<0.01%)	⬆️
e2e quarkus	31.51% <28.57%> (+<0.01%)	⬆️
e2e rust	30.97% <28.57%> (+0.04%)	⬆️
e2e springboot	30.99% <28.57%> (+0.02%)	⬆️
e2e typescript	31.47% <28.57%> (+<0.01%)	⬆️
integration	17.57% <0.00%> (-0.01%)	⬇️
unit macos-14	44.74% <47.61%> (+0.01%)	⬆️
unit macos-latest	44.74% <47.61%> (+0.01%)	⬆️
unit ubuntu-24.04-arm	44.90% <47.82%> (+0.01%)	⬆️
unit ubuntu-latest	45.65% <47.61%> (+0.01%)	⬆️
unit windows-latest	44.76% <47.61%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[matejvasek]

I know, I know… is not neat, but still better that that context …thing…

[matejvasek]

This way the ugly crap is isolated just in one package (cmd).

[lkingland]

I agree. The context thing was just a stop-gap for a better solution as we transition (hopefully) to a shared creds package that supports username/password more natively.

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [lkingland,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[matejvasek]

/help

[matejvasek]

/cherry-pick release-1.20

[knative-prow-robot]

@matejvasek: new pull request created: #3300

Details

In response to this:

/cherry-pick release-1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.