Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove geo replication for GCR #389

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

upodroid
Copy link
Member

@upodroid upodroid commented Aug 1, 2024

We have been doing geo-replication for a long time, but it's costly and we don't tell our end-users about it.

It costs about 4x to store images in Artifact Registry vs Container Registry. 0.10 USD vs 0.026 USD for a multiregion GCS bucket.

image

Storing in just gcr.io/knative-nightly which is the US multi-region should be sufficient.

/cc @dprotaso @cardil

@knative-prow knative-prow bot requested review from cardil and dprotaso August 1, 2024 23:06
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 1, 2024
@dprotaso
Copy link
Member

dprotaso commented Aug 1, 2024

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2024
Copy link

knative-prow bot commented Aug 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dprotaso
Copy link
Member

dprotaso commented Aug 1, 2024

/cherry-pick release-1.15

@knative-prow-robot
Copy link

@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.15 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dprotaso
Copy link
Member

dprotaso commented Aug 1, 2024

/cherry-pick release-1.14

@knative-prow-robot
Copy link

@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dprotaso
Copy link
Member

dprotaso commented Aug 1, 2024

Note - for the changes to take effect in release branches downstream repos need to update their knative.dev/hack dependency

@knative-prow knative-prow bot merged commit 441a19f into knative:main Aug 1, 2024
6 checks passed
@knative-prow-robot
Copy link

@dprotaso: new pull request created: #390

In response to this:

/cherry-pick release-1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dprotaso
Copy link
Member

dprotaso commented Aug 1, 2024

Also @upodroid to save on cost should we delete the extra images in those regions?

@knative-prow-robot
Copy link

@dprotaso: new pull request created: #391

In response to this:

/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@upodroid
Copy link
Member Author

upodroid commented Aug 1, 2024

I will delete the registries in knative-nightly project today.

I haven't migrated the prod one yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants