Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ppc64le]: Updated job config for release-1.15 for ppc64le #492

Closed
wants to merge 1 commit into from

Conversation

valen-mascarenhas14
Copy link
Contributor

Signed-off-by: Valen Mascarenhas Valen.Mascarenhas@ibm.com

Which issue(s) this PR fixes:

This PR updates the ppc64le specific job config for release 1.15 for operator, client, serving, eventing and eventing-reconciler and fixes the chainguard image issue for ppc64le.

@knative-prow knative-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 29, 2024
Copy link

knative-prow bot commented Jul 29, 2024

Hi @valen-mascarenhas14. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 29, 2024
@knative-prow knative-prow bot requested review from mgencur and upodroid July 29, 2024 16:41
@valen-mascarenhas14
Copy link
Contributor Author

@upodroid @dprotaso can you please approve this PR?

@valen-mascarenhas14
Copy link
Contributor Author

@upodroid Could you please merge this PR if everything's fine ?

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2024
Copy link

knative-prow bot commented Jul 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: upodroid, valen-mascarenhas14

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2024
Copy link

knative-prow bot commented Jul 31, 2024

@valen-mascarenhas14: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-infra-validate-own-testgrid-yaml 3c73aa9 link true /test pull-infra-validate-own-testgrid-yaml

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@valen-mascarenhas14
Copy link
Contributor Author

/retest

Copy link

knative-prow bot commented Jul 31, 2024

@valen-mascarenhas14: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dsimansk
Copy link
Contributor

dsimansk commented Aug 1, 2024

I don't think new jobs are necessary. The issue seems to be ko and base image combination, per Serving PR. knative/serving#15407

That was cherry-picked to release-1.15 branch, but release job failed on e2e tests. I've triggered a new run.

https://prow.knative.dev/?job=release_serving_release-1.15_periodic

@dsimansk
Copy link
Contributor

dsimansk commented Aug 1, 2024

Once Serving release-1.15 jobs passed, the images are published in both s390x and ppc64 archs.

{
   "schemaVersion": 2,
   "mediaType": "application/vnd.oci.image.index.v1+json",
   "manifests": [
      {
         "mediaType": "application/vnd.oci.image.manifest.v1+json",
         "size": 918,
         "digest": "sha256:bb746b99bbcc86154c4fea433a324f2f92612a99ea9e8a14265a22755282834e",
         "platform": {
            "architecture": "amd64",
            "os": "linux"
         }
      },
      {
         "mediaType": "application/vnd.oci.image.manifest.v1+json",
         "size": 918,
         "digest": "sha256:6f1368aa67ba0aa1b4f0977e2612a5194dc3d5cb66b097dbb16a0bf52c188f2f",
         "platform": {
            "architecture": "arm",
            "os": "linux",
            "variant": "v7"
         }
      },
      {
         "mediaType": "application/vnd.oci.image.manifest.v1+json",
         "size": 918,
         "digest": "sha256:6506b39b93e5848f834f9ab63a920c94e09944b4c090d21bbfebce0df5457f0b",
         "platform": {
            "architecture": "arm64",
            "os": "linux"
         }
      },
      {
         "mediaType": "application/vnd.oci.image.manifest.v1+json",
         "size": 918,
         "digest": "sha256:eb3fc7e589ee635d42aa260742a53d971f6aac2eb557d5b16e11edf229ce5e07",
         "platform": {
            "architecture": "ppc64le",
            "os": "linux"
         }
      },
      {
         "mediaType": "application/vnd.oci.image.manifest.v1+json",
         "size": 918,
         "digest": "sha256:322c763c780c89becada954ae89c7ab5cc932b9c0ef8d2a01d06430bbec62b4d",
         "platform": {
            "architecture": "s390x",
            "os": "linux"
         }
      }
   ],
   "annotations": {
      "org.opencontainers.image.base.digest": "sha256:2dd40d6660115085ef09597f8951c4366dddb6f5351f0e4972b824e9e61abfb1",
      "org.opencontainers.image.base.name": "ghcr.io/wolfi-dev/static:alpine"
   }
}

@dsimansk
Copy link
Contributor

dsimansk commented Aug 1, 2024

@upodroid @dprotaso do you think this changes are needed?

With Serving's fix linked above and patch release published all required architectures. It seems to me this PR can be closed and also PR for s390x reverted.

#484

@dprotaso
Copy link
Member

dprotaso commented Aug 2, 2024

no the base image was changed to have s390x/ppc support - so we don't need this PR

@dprotaso dprotaso closed this Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants