Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop unnecessary external name svc #1029

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented Jan 9, 2025

When debugging the visibility split issues in knative-extensions/net-contour#1149 I realize we don't need the extra ExternalName K8s Service.

It was being used to supply a DNS entry that would map a host name to the contour internal envoy service.

As an alternative we can add a GATEWAY_HOST env var that will configure the conformance httpproxy app to just dial the envoy service directly.

@knative-prow knative-prow bot requested review from izabelacg and skonto January 9, 2025 05:04
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 9, 2025
@dprotaso
Copy link
Member Author

dprotaso commented Jan 9, 2025

@dprotaso
Copy link
Member Author

dprotaso commented Jan 9, 2025

/assign @skonto

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.14%. Comparing base (34f5e09) to head (67e5a22).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1029   +/-   ##
=======================================
  Coverage   93.14%   93.14%           
=======================================
  Files          36       36           
  Lines        1254     1254           
=======================================
  Hits         1168     1168           
  Misses         72       72           
  Partials       14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skonto
Copy link
Contributor

skonto commented Jan 13, 2025

How does this change affect Kourier, Istio?

@dprotaso
Copy link
Member Author

For kourier/istio should be fine. I think it should be fine for mesh as well.

@skonto
Copy link
Contributor

skonto commented Jan 13, 2025

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2025
Copy link

knative-prow bot commented Jan 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 402ac60 into knative:main Jan 13, 2025
27 checks passed
@dprotaso dprotaso deleted the drop-extra-external-name-svc branch January 13, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants