-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop unnecessary external name svc #1029
drop unnecessary external name svc #1029
Conversation
note: I tested the change in a wip commit here: knative-extensions/net-contour@c0ebfc8 it passed conformance tests here: https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative-extensions_net-contour/1149/integration-tests_net-contour_main/1877181980768997376 |
/assign @skonto |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1029 +/- ##
=======================================
Coverage 93.14% 93.14%
=======================================
Files 36 36
Lines 1254 1254
=======================================
Hits 1168 1168
Misses 72 72
Partials 14 14 ☔ View full report in Codecov by Sentry. |
How does this change affect Kourier, Istio? |
For kourier/istio should be fine. I think it should be fine for mesh as well. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
When debugging the visibility split issues in knative-extensions/net-contour#1149 I realize we don't need the extra ExternalName K8s Service.
It was being used to supply a DNS entry that would map a host name to the contour internal envoy service.
As an alternative we can add a
GATEWAY_HOST
env var that will configure the conformance httpproxy app to just dial the envoy service directly.