-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split up the networking/pkg
to separate packages
#670
Conversation
Codecov Report
@@ Coverage Diff @@
## main #670 +/- ##
==========================================
- Coverage 94.85% 94.85% -0.01%
==========================================
Files 38 41 +3
Lines 1245 1243 -2
==========================================
- Hits 1181 1179 -2
Misses 52 52
Partials 12 12
Continue to review full report at Codecov.
|
/assign @ZhiminXiang @carlisia @nak3 @psschwei |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@@ -0,0 +1,116 @@ | |||
/* | |||
Copyright 2018 The Knative Authors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: 2022
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, ZhiminXiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I can some boiler plate error as https://github.com/knative/networking/runs/6425664316?check_suite_focus=true but LGTM in general. As long as I checked pkg/deprecated_config.go can keep the compatibility. (If not, we should fix or revert 😈 ) |
Replaces: #465
Part of: knative/serving#9957
Note: I created
type
andfunc
aliases so this change should be backwards compatible