Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up the networking/pkg to separate packages #670

Merged
merged 8 commits into from
May 17, 2022

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented May 13, 2022

Replaces: #465

Part of: knative/serving#9957

  • bump go.mod to 1.17 and re-vendor
  • pull out config-network parsing to it's own package
  • split up knative.dev/pkg/network into seperate sub-packages
  • use new packages

Note: I created type and func aliases so this change should be backwards compatible

@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 13, 2022
@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #670 (059d607) into main (91dcb36) will decrease coverage by 0.00%.
The diff coverage is 95.38%.

@@            Coverage Diff             @@
##             main     #670      +/-   ##
==========================================
- Coverage   94.85%   94.85%   -0.01%     
==========================================
  Files          38       41       +3     
  Lines        1245     1243       -2     
==========================================
- Hits         1181     1179       -2     
  Misses         52       52              
  Partials       12       12              
Impacted Files Coverage Δ
pkg/http/proxy/bufferpool.go 100.00% <ø> (ø)
pkg/http/stats/request.go 100.00% <ø> (ø)
pkg/config/config.go 86.66% <78.57%> (ø)
pkg/http/error.go 100.00% <100.00%> (ø)
pkg/http/header/header.go 100.00% <100.00%> (ø)
pkg/http/probe/handler.go 100.00% <100.00%> (ø)
pkg/ingress/ingress.go 91.30% <100.00%> (ø)
pkg/k8s/ports.go 100.00% <100.00%> (ø)
pkg/status/status.go 96.35% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91dcb36...059d607. Read the comment docs.

@dprotaso
Copy link
Member Author

/assign @ZhiminXiang @carlisia @nak3 @psschwei

Copy link

@ZhiminXiang ZhiminXiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@@ -0,0 +1,116 @@
/*
Copyright 2018 The Knative Authors

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: 2022

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2022
@knative-prow
Copy link

knative-prow bot commented May 17, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, ZhiminXiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ZhiminXiang,dprotaso]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit f1ee84b into knative:main May 17, 2022
@nak3
Copy link
Contributor

nak3 commented May 17, 2022

I can some boiler plate error as https://github.com/knative/networking/runs/6425664316?check_suite_focus=true but LGTM in general.

As long as I checked pkg/deprecated_config.go can keep the compatibility. (If not, we should fix or revert 😈 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants