feat: create helm chart repository in gh-pages #1931
Conversation
|
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: patrickleet The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Welcome @patrickleet! It looks like this is your first PR to knative/operator 🎉 |
|
Hi @patrickleet. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
knative-prow
bot
added
needs-ok-to-test
|
example: https://patrickleet.github.io/knative-operator/ |
|
perhaps a better trigger than push to main could be used maybe on tag published but it wouldn't run until there was a new tag that way |
|
Amazing! |
try with helm index.yaml (@kromanow94) find all helm chart releases and put to index.yaml (@kromanow94) add chart description and version (@kromanow94) add bash script for helm repo index.yaml generation from releases (@kromanow94) script doesnt need token, rm unused python version, move to hack/, run from publish-helm gha workflow push changes remove unused py file create clean branch for gh-pages dont delete the script we need typo typo gh-pages html remove debug logs git fetch if statement wasnt working copy needed files from hack to .tmp to use in empty gh-pages debug debug cleanup debug logs remove test file fix: token not needed to install helm
|
@houshengbo you still the person to tag to review this? |
Fixes #1851 and fixes #1881
Also requested in #751, #914, #1525,
Proposed Changes
This publishes a gh-pages branch as a helm repo for the package.
You will need to go to repo settings and enable it (Settings -> Pages):
I cherry picked @kromanow94's commits from #1851 but they got squashed out. I modified that script, moved it to hack/, created a go template to render HTML from the index.yaml file, and added a github workflow that handles all of that.
It runs on every push to main but only commits to gh-pages if there are differences, which only happens when y'all release.
This allows users to use Helm chart via:
Release Note