Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Tracker should return an error when required fields are omitted #150

Closed
mattmoor opened this issue Nov 1, 2018 · 0 comments
Closed

The Tracker should return an error when required fields are omitted #150

mattmoor opened this issue Nov 1, 2018 · 0 comments
Labels
area/API kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@mattmoor
Copy link
Member

mattmoor commented Nov 1, 2018

See knative/serving#2372 for an example of this. Sanitizing inputs would have caught this.
@knative-prow-robot knative-prow-robot added area/API kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Nov 1, 2018
@mattmoor mattmoor mentioned this issue Nov 1, 2018
Closed
mattmoor added a commit to mattmoor/pkg that referenced this issue Nov 1, 2018
@mattmoor
Reject ObjectReferences missing key elements.
5d71ee5 
Fixes: knative#150
@mattmoor mattmoor mentioned this issue Nov 1, 2018
Merged
knative-prow-robot pushed a commit that referenced this issue Nov 1, 2018
@mattmoor @knative-prow-robot
Reject ObjectReferences missing key elements. (#151)
f83edbe 
Fixes: #150
@evankanderson evankanderson mentioned this issue Nov 1, 2018
Merged
chengjingtao pushed a commit to katanomi/knative-pkg that referenced this issue Oct 22, 2024
@l-qing
feat: loaded resources support list of fake client (knative#150)
6377757 
This logic can be removed after upgrading to controller-runtime v0.10.1
Ref: kubernetes-sigs/controller-runtime#1662

Co-authored-by: qingliu <qingliu@alauda.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/API kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattmoor @knative-prow-robot