Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add controller options to set reconciler DemoteFunc #1683

Closed
lionelvillard opened this issue Sep 3, 2020 · 3 comments · Fixed by #2033
Closed

Add controller options to set reconciler DemoteFunc #1683

lionelvillard opened this issue Sep 3, 2020 · 3 comments · Fixed by #2033
Assignees
@lionelvillard
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@lionelvillard
Copy link
Member

Expected Behavior

Being able to set DemoteFunc when creating a controller.

Actual Behavior

Not possible.

Steps to Reproduce the Problem

Additional Info

Receive adapter internal state must be updated when demoting a bucket
@lionelvillard
Copy link
Member Author

/assign

@lionelvillard
Copy link
Member Author

/cc @mattmoor

First step to remove the leader election fork in eventing.

@lionelvillard lionelvillard mentioned this issue Sep 4, 2020
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2020

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 3, 2020
@github-actions github-actions bot closed this as completed Jan 2, 2021
@lionelvillard lionelvillard reopened this Feb 22, 2021
@lionelvillard lionelvillard mentioned this issue Feb 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lionelvillard lionelvillard

Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add demoteFunc controller option lionelvillard/pkg
1 participant
@lionelvillard