Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mtping now uses bucket-based leader election #4009

Merged
merged 8 commits into from
Sep 21, 2020

Conversation

lionelvillard
Copy link
Member

Depends on #4008
Depends on knative/pkg#1683

Proposed Changes

  • 🎁 the mt adapter main now uses bucket-based leader election
  • πŸ—‘οΈ remove eventing leader election fork

Release Note


Docs

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 4, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 4, 2020
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 4, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2020
@knative-test-reporter-robot

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-conformance-tests 2020-09-05 22:53:44 +0000 UTC 1/3

Automatically retrying due to test flakiness...
/test pull-knative-eventing-conformance-tests

@knative-test-reporter-robot

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-integration-tests 2020-09-05 22:53:45.004 +0000 UTC 1/3

Automatically retrying due to test flakiness...
/test pull-knative-eventing-integration-tests

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 6, 2020
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 14, 2020
@lionelvillard lionelvillard force-pushed the bucket-ha branch 2 times, most recently from 723840b to 29df903 Compare September 14, 2020 16:25
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 16, 2020
@knative-prow-robot knative-prow-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 21, 2020
@lionelvillard lionelvillard changed the title WIP: mtping now uses bucket-based leader election mtping now uses bucket-based leader election Sep 21, 2020
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 21, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/adapter/mtping/adapter.go 79.5% 77.8% -1.7
pkg/adapter/v2/config.go 60.0% 55.6% -4.4
pkg/adapter/v2/context.go Do not exist 100.0%
pkg/adapter/v2/main.go 61.1% 51.1% -9.9
pkg/adapter/v2/main_message.go 55.6% 52.6% -2.9

@cr22rc
Copy link
Contributor

cr22rc commented Sep 21, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2020
@lionelvillard
Copy link
Member Author

/test pull-knative-eventing-unit-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants