Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a hexadecimal representation for the example checksum. #1374

Merged
merged 1 commit into from
Jun 3, 2020
Merged

Use a hexadecimal representation for the example checksum. #1374

merged 1 commit into from
Jun 3, 2020

Conversation

markusthoemmes
Copy link
Contributor

As per @julz comment on knative/serving#8123 this is more usual. I like it better anyway as the Checksum function now controls the representation.

/assign @julz

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 3, 2020
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 3, 2020
@julz
Copy link
Member

julz commented Jun 3, 2020

👍 love it.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2020
@markusthoemmes
Copy link
Contributor Author

/assign @mattmoor

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-pkg-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
configmap/example.go Do not exist 100.0%
configmap/hash-gen/main.go Do not exist 65.2%
webhook/configmaps/configmaps.go 93.9% 94.3% 0.3

mattmoor
mattmoor reviewed Jun 3, 2020
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markusthoemmes, mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2020
@knative-prow-robot knative-prow-robot merged commit b0dc366 into knative:master Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor left review comments

@tcnghia tcnghia Awaiting requested review from tcnghia

Assignees

@julz julz

@mattmoor mattmoor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@markusthoemmes @julz @knative-metrics-robot @knative-prow-robot @mattmoor @googlebot