Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop kubeclient struct #2151

Merged
merged 1 commit into from
Jun 10, 2021
Merged

drop kubeclient struct #2151

merged 1 commit into from
Jun 10, 2021

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented Jun 9, 2021 •
edited
Loading

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 9, 2021
@knative-prow-robot knative-prow-robot added area/test-and-release approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 9, 2021
@dprotaso
Copy link
Member Author

dprotaso commented Jun 9, 2021

/hold

will remove some stuff downstream

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 9, 2021
@codecov
Copy link

codecov bot commented Jun 9, 2021 •
edited
Loading

Codecov Report

Merging #2151 (1929424) into main (c1db741) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2151      +/-   ##
==========================================
+ Coverage   67.56%   67.58%   +0.02%     
==========================================
  Files         215      215              
  Lines        9098     9098              
==========================================
+ Hits         6147     6149       +2     
+ Misses       2676     2675       -1     
+ Partials      275      274       -1
Impacted Files Coverage Δ
test/gcs/mock/mock.go 91.39% <0.00%> (+1.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1db741...1929424. Read the comment docs.

@dprotaso dprotaso changed the title drop kubeclient struct [wip] drop kubeclient struct Jun 9, 2021
@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 9, 2021
@dprotaso
Copy link
Member Author

dprotaso commented Jun 9, 2021

Just waiting for downstream PRs to merge

@dprotaso dprotaso changed the title [wip] drop kubeclient struct drop kubeclient struct Jun 10, 2021
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 10, 2021
@dprotaso
Copy link
Member Author

unholding - the remaining repos will be resolved once they picked up the eventing change

markusthoemmes
markusthoemmes approved these changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@markusthoemmes markusthoemmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, markusthoemmes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dprotaso
Copy link
Member Author

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 10, 2021
@knative-prow-robot knative-prow-robot merged commit c96c7be into knative:main Jun 10, 2021
@dprotaso dprotaso deleted the kubeclient-cleanup branch June 11, 2021 19:23
@mattmoor mattmoor mentioned this pull request Jul 30, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusthoemmes markusthoemmes markusthoemmes approved these changes

Assignees

@markusthoemmes markusthoemmes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dprotaso @knative-prow-robot @markusthoemmes