Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop unused stackdriver unit test workflow #2192

Merged
merged 1 commit into from
Jul 15, 2021

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented Jul 15, 2021

Fixes: #2173

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 15, 2021
@dprotaso dprotaso changed the title drop unused workflow drop unused stackdriver unit test workflow Jul 15, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 15, 2021
@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #2192 (b68d7ee) into main (00fa154) will decrease coverage by 1.45%.
The diff coverage is 70.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2192      +/-   ##
==========================================
- Coverage   67.58%   66.13%   -1.46%     
==========================================
  Files         215      221       +6     
  Lines        9098     9257     +159     
==========================================
- Hits         6149     6122      -27     
- Misses       2675     2861     +186     
  Partials      274      274              
Impacted Files Coverage Δ
.../injection-gen/generators/reconciler_controller.go 0.00% <ø> (ø)
leaderelection/config.go 77.27% <ø> (ø)
logging/warning_handler.go 0.00% <0.00%> (ø)
metrics/config_observability.go 92.00% <ø> (ø)
source/source_stats_reporter.go 84.90% <ø> (ø)
test/cleanup.go 0.00% <0.00%> (ø)
test/clients.go 0.00% <ø> (ø)
test/request.go 0.00% <0.00%> (ø)
test/spoof/error_checks.go 76.92% <0.00%> (-6.42%) ⬇️
tracing/opencensus.go 46.26% <ø> (+3.21%) ⬆️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7764284...b68d7ee. Read the comment docs.

@dprotaso
Copy link
Member Author

/assign @skonto

@skonto
Copy link
Contributor

skonto commented Jul 15, 2021

Looks good, let's deal with the codecov issue seperately.

@skonto
Copy link
Contributor

skonto commented Jul 15, 2021

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2021
@knative-prow-robot knative-prow-robot merged commit 591cb89 into knative:main Jul 15, 2021
@dprotaso dprotaso deleted the drop-no-stackdriver-test branch July 15, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove stack driver exporter
3 participants