Drop spec.generation support #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
the
do-not-merge/hold
knative-prow-robot
added
the
size/L
dprotaso
force-pushed
the
drop-spec-generation-support
branch
2 times, most recently
from
583ab64 to
b9969e7
Compare
|
/assign @vaikas-google I'll be glad to see this gone. I'll let @vaikas-google do the honors :) |
|
awesome!! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, vaikas-google The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
With Kubernetes 1.11+ metadata.generation now increments properly when the status subresource is enabled on CRDs For more details see: knative/serving#643
dprotaso
force-pushed
the
drop-spec-generation-support
branch
from
b9969e7 to
6b780d9
Compare
|
The following is the coverage report on pkg/.
|
|
/lgtm @dprotaso Remove the hold when you are ready to pull the trigger on the other repos? |
|
everything went green /hold cancel |
knative-prow-robot
removed
the
do-not-merge/hold
chengjingtao
pushed a commit
to katanomi/knative-pkg
that referenced
this pull request
Oct 22, 2024
…ve#234) 1. add list cluster namespaces implemention for MultiClusterClient 2. add MultiClusterClient into testing context Signed-off-by: jtcheng <jtcheng@alauda.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Kubernetes 1.11+ metadata.generation now increments properly
when the status subresource is enabled on CRDs
Thus we can drop
spec.generationAddresses part of knative/serving#643
Holding for now - since I will prepare PRs in other repos incorporating this change
/hold