Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pkg/pool #2568

Merged
merged 1 commit into from
Aug 15, 2022
Merged

Remove pkg/pool #2568

merged 1 commit into from
Aug 15, 2022

Conversation

imjasonh
Copy link
Member

Fixes #2556

Changes

🗑️ Remove pkg/pool

/kind cleanup

Release Note

pkg/pool is removed, use errgroup instead

Docs

NONE

cc @dprotaso

@knative-prow knative-prow bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/API labels Aug 11, 2022
@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #2568 (dd67813) into main (7b8b060) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2568      +/-   ##
==========================================
- Coverage   81.40%   81.32%   -0.09%     
==========================================
  Files         163      162       -1     
  Lines        9740     9695      -45     
==========================================
- Hits         7929     7884      -45     
  Misses       1574     1574              
  Partials      237      237              

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dprotaso
Copy link
Member

/lgtm
/approve
/override Downstream Tekton / Unit Test (tektoncd/chains) (pull_request)
/override Downstream Tekton / Unit Test (tektoncd/pipeline) (pull_request)

@knative-prow
Copy link

knative-prow bot commented Aug 15, 2022

@dprotaso: /override requires a failed status context, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • Downstream Tekton / Unit Test (tektoncd/chains) (pull_request)
  • Downstream Tekton / Unit Test (tektoncd/pipeline) (pull_request)

Only the following failed contexts/checkruns were expected:

  • EasyCLA
  • Unit Test (tektoncd/chains)
  • Unit Test (tektoncd/pipeline)
  • build-tests_pkg_main
  • integration-tests_pkg_main
  • tide
  • unit-tests_pkg_main

In response to this:

/lgtm
/approve
/override Downstream Tekton / Unit Test (tektoncd/chains) (pull_request)
/override Downstream Tekton / Unit Test (tektoncd/pipeline) (pull_request)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2022
@dprotaso
Copy link
Member

/override Unit Test (tektoncd/chains)
/override Unit Test (tektoncd/pipeline)

@knative-prow
Copy link

knative-prow bot commented Aug 15, 2022

@dprotaso: Overrode contexts on behalf of dprotaso: Unit Test (tektoncd/chains), Unit Test (tektoncd/pipeline)

In response to this:

/override Unit Test (tektoncd/chains)
/override Unit Test (tektoncd/pipeline)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow
Copy link

knative-prow bot commented Aug 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, imjasonh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2022
@dprotaso
Copy link
Member

override Tekton - since I assume you'll fix those :)

@dprotaso
Copy link
Member

dprotaso commented Aug 15, 2022

/retest

flake - TestDialTLSWithBackoffSuccess

@knative-prow knative-prow bot merged commit 4f6a775 into knative:main Aug 15, 2022
@imjasonh
Copy link
Member Author

Chains fix: tektoncd/chains#517 -- bumps cosign and knative/pkg deps
Pipeline fix: tektoncd/pipeline#5311 -- bumps knative/pkg dep, accounts for new changeset.Get behavior

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate pool in favor of errgroup?
2 participants