Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump net and text packages #2692

Merged
merged 2 commits into from
Feb 24, 2023
Merged

bump net and text packages #2692

merged 2 commits into from
Feb 24, 2023

Conversation

KauzClay
Copy link
Contributor

@KauzClay KauzClay commented Feb 24, 2023 •
edited
Loading

Changes

  • 🐛 address vulnerabilities:
  • golang.org/x/text 0.3.7 -> 0.3.8 for GHSA-69ch-w2m2-3vjp
  • golang.org/x/net v0.0.0-20220722155237-a158d28d115b -> 0.0.0-20220906165146-f3363e06e74c for GHSA-69cg-p879-7622
  • I don't know if this is the proper way to do this.
  • Can this get backported to the 1.8 branch as well?

/kind

Fixes #

Release Note

Docs

@knative-prow
Copy link

knative-prow bot commented Feb 24, 2023

@KauzClay: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

/kind

Fixes #

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot requested review from carlisia and ReToCode February 24, 2023 17:05
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 24, 2023
@KauzClay KauzClay changed the title bump net and text packages [wip] bump net and text packages Feb 24, 2023
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 24, 2023
@pierDipi @KauzClay
Allow reconcilers to listen to leader promotion events (knative#2688)
2b7ef49 
* Generator: allow reconcilers to listen to leader promotion events

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Run hack/update-codegen.sh

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

---------

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 24, 2023
@codecov
Copy link

codecov bot commented Feb 24, 2023 •
edited
Loading

Codecov Report

Base: 81.29% // Head: 81.26% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (59583d2) compared to base (2fdd6bf).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2692      +/-   ##
==========================================
- Coverage   81.29%   81.26%   -0.04%     
==========================================
  Files         163      163              
  Lines        9902     9902              
==========================================
- Hits         8050     8047       -3     
- Misses       1610     1612       +2     
- Partials      242      243       +1
Impacted Files Coverage Δ
controller/controller.go 88.06% <0.00%> (-0.72%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@KauzClay KauzClay changed the title [wip] bump net and text packages bump net and text packages Feb 24, 2023
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 24, 2023
@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2023
@knative-prow
Copy link

knative-prow bot commented Feb 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, KauzClay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2023
@knative-prow knative-prow bot merged commit 0591b75 into knative:main Feb 24, 2023
This was referenced Feb 24, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlisia carlisia Awaiting requested review from carlisia

@ReToCode ReToCode Awaiting requested review from ReToCode

Assignees

@dprotaso dprotaso

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KauzClay @dprotaso @pierDipi