Add dependabot and auto update deps #2768
Conversation
knative-prow
bot
added
the
size/M
knative-prow
bot
added
the
approved
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2768 +/- ##
=======================================
Coverage 81.75% 81.75%
=======================================
Files 167 167
Lines 10201 10201
=======================================
Hits 8340 8340
Misses 1614 1614
Partials 247 247 ☔ View full report in Codecov by Sentry. |
|
|
||
| - name: Run ./hack/update-deps.sh | ||
| working-directory: ./src/github.com/${{ github.repository }} | ||
| run: ./hack/update-deps.sh |
There was a problem hiding this comment.
You'll want to run update-codegen as well
There was a problem hiding this comment.
Okay, update-codegen.sh includes update-deps.sh so replaced with update-codegen.sh
There was a problem hiding this comment.
We'll want to run update-codegen.sh after update-deps.sh - updates in dependencies could change the generated code (ie. generating clients)
There was a problem hiding this comment.
Okay, updated. Just note, the client codes (k8s.io/* and knative.dev/* are ignored by dependabot so it is not supposed to be bumped automatically.
|
/assign @kvmware |
| with: | ||
| ref: ${{ github.head_ref }} | ||
| path: ./src/github.com/${{ github.repository }} | ||
| fetch-depth: 0 |
There was a problem hiding this comment.
Curious on these settings some seem to be the defaults and why do you want all history?
There was a problem hiding this comment.
Just used with same value in .github/workflows/knative-downstream.yaml. It seems that it was added for some reason #2265 (comment)
If we remove it, I think we should use consistent value in all action.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, nak3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
As per title, this is same with knative-extensions/net-gateway-api#498.
Fix #2759