Add WEBHOOK_DISABLE_NAMESPACE_OWNERSHIP env-var

[thesuperzapper]

Changes

• Added a new environment variable WEBHOOK_DISABLE_NAMESPACE_OWNERSHIP to set the DisableNamespaceOwnership webhook option added by 🧹 Give users the ability to disable namespace ownership of webhook configurations #3095
• This allows the downstream apps (like Knative Serving) to make use of the ability to not have the Namespace own the webhook configurations, which breaks ArgoCD: fix using KNative with ArgoCD (don't set ownerReferences for webhooks) serving#15483

/kind enhancement

Related knative/serving#15483

Release Note

Added `WEBHOOK_DISABLE_NAMESPACE_OWNERSHIP` env-var to set `DisableNamespaceOwnership` in `webhook.Options`

Docs

[knative-prow]

Welcome @thesuperzapper! It looks like this is your first PR to knative/pkg 🎉

[knative-prow]

Hi @thesuperzapper. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[thesuperzapper]

@dprotaso this is a follow up to #3095 so that we can actually use it in KNative Serving and fix ArgoCD.

[dprotaso]

/ok-to-test

[dprotaso]

Can we default this as false and have the return type be bool

[thesuperzapper]

@dprotaso the behavior I was intending was that WEBHOOK_DISABLE_NAMESPACE_OWNERSHIP overrides the DisableNamespaceOwnership webhook option only when the env-var is set.

To do this, I need to be able to distinguish between an unset env-var and a false one:

https://github.com/knative/pkg/pull/3103/files#diff-71e3f02004a234858e10c42bf73e303ba86e5000ad4a1a95ccf5f6d94447c5e8R169-R174

[dprotaso]

/hold

see: knative/serving#15483 (comment)

[thesuperzapper]

@dprotaso I was saying in knative/serving#15483 (comment), we should make both changes (that is, set the controller flag to false, AND let users disable the owner references fully).

As long as you agree on the way this PR does the disabling, it should be safe to merge.

Also, it would be a real shame if KServe/Kubeflow/deployKF had to run a forked version of kNative for this simple change that doesn't change any default behavior.

[dprotaso]

/lgtm
/approve

I'll merge this in to unblock for now - but I don't consider this functionality stable. We may make edits to the mechanism in a future date especially if ArgoCD merges the PR mentioned in the serving issue.

/cherry-pick release-1.16

[knative-prow-robot]

@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.16 in a new PR and assign it to you.

In response to this:

/lgtm
/approve

I'll merge this in to unblock for now - but I don't consider this functionality stable. We may make edits to the mechanism in a future date especially if ArgoCD merges the PR mentioned in the serving issue.

/cherry-pick release-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, thesuperzapper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• webhook/OWNERS [dprotaso]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dprotaso]

/hold cancel

[dprotaso]

OpenCensus flake

/retest

[knative-prow-robot]

@dprotaso: new pull request created: #3106

In response to this:

/lgtm
/approve

I'll merge this in to unblock for now - but I don't consider this functionality stable. We may make edits to the mechanism in a future date especially if ArgoCD merges the PR mentioned in the serving issue.

/cherry-pick release-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.