-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serializing/Deserializing Logging and Metrics configs #656
Conversation
nachocano
commented
Sep 10, 2019
- Moving to pkg a way to serialize/deserialize logging and metric configMaps. This is a modified version of the code written by @n3wscott here, but as will be used in many places, we are moving it down to pkg.
/assign @n3wscott |
The following is the coverage report on pkg/.
|
/lgtm |
@yanweiguo this one is ready for approval. I think @n3wscott doesn't have approval in these folder |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nachocano, yanweiguo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |