Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up Route test code. #1221

Closed
mattmoor opened this issue Jun 14, 2018 · 2 comments
Closed

Clean up Route test code. #1221

mattmoor opened this issue Jun 14, 2018 · 2 comments
Assignees
@tcnghia
Labels
area/API API objects and controllers kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@mattmoor
Copy link
Member

Refactor the Route controller tests to use the pattern adopted in #1216.
@google-prow-robot google-prow-robot added area/API API objects and controllers kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jun 14, 2018
@mattmoor mattmoor mentioned this issue Jul 4, 2018
Merged
@mattmoor
Copy link
Member Author

mattmoor commented Jul 8, 2018

I did a significant portion of this in the linked PR (and an unlinked follow up that covers failure paths). I think what remains involves covering inactive revision paths.

@tcnghia can you finish this off?

@mattmoor
Copy link
Member Author

This is done enough for now

nak3 added a commit to nak3/serving that referenced this issue Aug 31, 2022
@nak3
Update CI script to generate 4.11 config (knative#1221)
b8c3e86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tcnghia tcnghia

Labels
area/API API objects and controllers kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tcnghia @mattmoor @google-prow-robot