Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoC: Check if we can leverage a Multi-SAN approach for internal-encryption #13820

Closed
ReToCode opened this issue Mar 29, 2023 · 7 comments
Closed
Assignees
Labels
area/networking triage/accepted Issues which should be fixed (post-triage)

Comments

@ReToCode
Copy link
Member

ReToCode commented Mar 29, 2023

Description

As discussed in https://docs.google.com/document/d/1YdcdBVg_zpT4WSNRsWlihut5JuLddOTIggFvLni3A28/edit#heading=h.n8a530nnrb we would like to leverage a multi SAN approach to handle tls traffic for:

User --> Ingress Gateway --> Activator
User --> Ingress Gateway --> Queue-Proxy / KService

This results in two certificates that need to be trusted by the Ingress Gateway (one from the activator with a static SAN and one for Queue-Proxy with a SAN that contains the namespace of the KService). Envoy can be configured to trust multiple SANs for one upstream connection.

/area networking

If this works, #12797 can be omitted.

@ReToCode
Copy link
Member Author

/cc @davidhadas

@davidhadas
Copy link
Contributor

Refer to match_typed_subject_alt_names field of envoy as discussed in https://docs.google.com/document/d/1XE7UzgQlVVtAb7ULSqOyKCaIHtm8zMF35ainp1JmwyY/

@ReToCode
Copy link
Member Author

@KauzClay would you mind reporting your findings with contour here?

@KauzClay
Copy link
Contributor

KauzClay commented Jul 24, 2023

Currently, Contour does not allow trusting mutliple SANs for a backend.

I've started an issue with them to potentially change this: projectcontour/contour#5520

I'm trying to work with them on this when I can.

@ReToCode
Copy link
Member Author

ReToCode commented Aug 3, 2023

To summarize the findings:

  • Kourier supports multiple SANs
  • Istio supports multiple SANS
  • Contour does not support it yet, but might in the future --> We fall back to Activator always in path for this
  • Gateway-API does not support it yet, but might in the future --> We fall back to Activator always in path for this

/close

@knative-prow knative-prow bot closed this as completed Aug 3, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 3, 2023

@ReToCode: Closing this issue.

In response to this:

To summarize the findings:

  • Kourier supports multiple SANs
  • Istio supports multiple SANS
  • Contour does not support it yet, but might in the future --> We fall back to Activator always in path for this
  • Gateway-API does not support it yet, but might in the future --> We fall back to Activator always in path for this

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dprotaso
Copy link
Member

dprotaso commented Aug 9, 2023

I've been talking to the upstream maintainers

Contour does not support it yet, but might in the future

Contour prioritized multi-san in their next release
see: projectcontour/contour#5520

Gateway-API does not support it yet, but might in the future

The latest update to the Backend TLS GEP PR added support for multi-san
see: kubernetes-sigs/gateway-api#2113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/networking triage/accepted Issues which should be fixed (post-triage)
Projects
Development

No branches or pull requests

4 participants