Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Conformance Test Suite for Internal Encryption #13855

Open
KauzClay opened this issue Apr 6, 2023 · 0 comments
Open

Create Conformance Test Suite for Internal Encryption #13855

KauzClay opened this issue Apr 6, 2023 · 0 comments
Labels
area/API API objects and controllers area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features kind/feature Well-understood/specified features, ready for coding. triage/accepted Issues which should be fixed (post-triage)

Comments

@KauzClay
Copy link
Contributor

KauzClay commented Apr 6, 2023

/area API
/area networking
/area test-and-release

Describe the feature

In support of #11906
notes/discussion

We should cover the following scenarios:

  • Basic test to call local ingress-gateway with TLS and check the returned certificate
  • Basic test to call activator (without ingress-gateway) with TLS and check the returned certificates
  • Basic test to call QP (without ingress-gateway and activator) with TLS and check the returned certificates
  • Test with domain-mapping, check if the call to the ingress-gateway and local ingress gateway is done with TLS, check the returned certificates
  • Test with http2, check the returned certificates

Depending on the implementation decisions, we should also add:

  • Test to check if the ingress implementation is checking the upstream SAN with multiple values (activator SAN + QP SAN)
  • Define and check what SNI information the ingress-gateway sends to upstream backends.

Some or all of these tests may need to also existing the Networking repo, since we will want to make sure ingress-controllers call and validate upstream connections correctly (so instead of activator/qp we can use a custom pod to check).

@KauzClay KauzClay added the kind/feature Well-understood/specified features, ready for coding. label Apr 6, 2023
@knative-prow knative-prow bot added area/API API objects and controllers area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features labels Apr 6, 2023
@ReToCode ReToCode added the triage/accepted Issues which should be fixed (post-triage) label Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/API API objects and controllers area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features kind/feature Well-understood/specified features, ready for coding. triage/accepted Issues which should be fixed (post-triage)
Projects
Status: No status
Development

No branches or pull requests

2 participants