-
Notifications
You must be signed in to change notification settings - Fork 46
Add a new issuer configuration to net-certmanager for system-internal-tls certificates #627
Add a new issuer configuration to net-certmanager for system-internal-tls certificates #627
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ReToCode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #627 +/- ##
==========================================
- Coverage 89.68% 87.93% -1.76%
==========================================
Files 5 5
Lines 378 406 +28
==========================================
+ Hits 339 357 +18
- Misses 27 36 +9
- Partials 12 13 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall but we should add a conformance test in https://github.com/knative/networking/tree/main/test/conformance/certificate/nonhttp01 ?
pkg/reconciler/certificate/resources/cert_manager_certificate.go
Outdated
Show resolved
Hide resolved
7fdb745
to
c699f69
Compare
c699f69
to
95439a3
Compare
/unhold Networking PR is merged: knative/networking#891, conformance tests is tracked in knative/serving#13855. So this is ready to be reviewed again @dprotaso @nak3 @skonto |
Tests pass at the Serving side besides the long standing issue with the http_serving tests flakiness. |
Changes
internal
->local
to be aligned with renamed encryption flagssystemInternalIssuerRef
to sign certificates forsystem-internal-tls
knative-selfsigned-issuer
to not conflict withsystem-internal-tls
CertificateTypeLabelKey
to distinguish between the three different certificate typesknative.dev/issuer-install
to optionally filter out the selfsigned issuers when installing/hold needs knative/networking#891 to be merged first
/hold wait for results of discussion in next Serving WG
/kind enhancement
Fixes knative/serving#14625
Release Note
Docs
Will be added once the feature is completed end to end.