Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Route, add capability for watching for changes to Configuration so when Configuration gets updated, we'll pick up changes) #2

Closed
dewitt opened this issue Jan 26, 2018 · 1 comment
Assignees
Labels
kind/feature Well-understood/specified features, ready for coding. small

Comments

@dewitt
Copy link
Contributor

dewitt commented Jan 26, 2018

No description provided.

@dewitt dewitt added kind/feature Well-understood/specified features, ready for coding. small labels Jan 26, 2018
@dewitt dewitt changed the title In helioservice, add capability for watching for changes to HRT so when HRT gets updated, we'll pick up changes) In elaservice, add capability for watching for changes to ERT so when ERT gets updated, we'll pick up changes) Jan 29, 2018
@vaikas
Copy link
Contributor

vaikas commented Feb 8, 2018

PR #104 added watches for the Revision watching Endpoints. We should do something similar for the ElaService watching RevisionTemplates and when Status.Latest changes if the traffic is set to follow a RevisionTemplate, we should update the routerules to point to newly ready k8s service that the new Revision has.

@yanweiguo yanweiguo self-assigned this Feb 13, 2018
@yanweiguo yanweiguo changed the title In elaservice, add capability for watching for changes to ERT so when ERT gets updated, we'll pick up changes) In Route, add capability for watching for changes to Configuration so when Configuration gets updated, we'll pick up changes) Feb 15, 2018
knative-prow-robot pushed a commit that referenced this issue Nov 30, 2018
* Move kpa-class autoscaling into autoscaling/kpa package.

* Rename autoscaling.go as kpa.go.

* Stub hpa-class controller.

* Reconcile HorizontalPodAutoscalers.

* Rename kpa_* files as pa_*.

* Rename usage of kpa to pa in pa_types.

* Reconcile PodAutoscaler in Revision controller.

* Disallow PodAutoscaler class change.

* Revert PodAutoscaler annotation reconciliation.

* Validate PodAutoscaler metric and immutable class.

* Set TargetCPUUtilizationPercentage on HPA.

* Unit test for KPA reconciler ignoring non-KPA class PodAutoscaler.

* Add HPA Reconcile unit test.

* Non HPA-class PodAutoscaler unit test.

* Create HPA error unit test.

* Use TableTest.

* Test target annotation reconciliation.

* Build and unit test fixes.

* Fix search-and-replace of legitimate kpa to pa.

* Remove unused OPS constant.

* Use name annotationInt32 instead of scaleBoundInt32.

* Use domain-style class values.

* Fix type in annotation key comment.

* Chain metric validation as another Also.

* Put annotation key in square brackets in validation error.

* Reconcile HPA-class PodAutoscalers when HPAs change.

* Use AnnotationFilterFunc on class annotation.

* Remove unused PodAutoscalerOption.

* Create new OwnerReference for HPA.

* Fix merge error.

* Add HPA class unit test.

* Move rename KPAOption as PodAutoscalerOption.

* Do not filter endpoints which do not have class annotation.
StrongMonkey pushed a commit to StrongMonkey/serving that referenced this issue Aug 1, 2019
mgencur added a commit to mgencur/serving-1 that referenced this issue Nov 27, 2020
mgencur pushed a commit to mgencur/serving-1 that referenced this issue Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Well-understood/specified features, ready for coding. small
Projects
None yet
Development

No branches or pull requests

3 participants