Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activator leaks metrics publicly #2043

Closed
scothis opened this issue Sep 17, 2018 · 3 comments
Closed

Activator leaks metrics publicly #2043

scothis opened this issue Sep 17, 2018 · 3 comments
Assignees
@tanzeeb
Labels
area/autoscale kind/bug Categorizes issue or PR as related to a bug.

Comments

@scothis
Copy link
Contributor

scothis commented Sep 17, 2018

Expected Behavior

When making a request to a deactive service /metrics, I expect the service to activate and handle the request.

Actual Behavior

The activator's /metrics endpoint hijacks the request and returns it's own internal metrics

Steps to Reproduce the Problem

  1. create a service
  2. wait for it to scale to zero
  3. make a request to the service with the path /metrics
  4. see that the response is activator's metrics

Additional Info

Metrics and other control plane request handlers must run on a different port in order to not collide with the data plane.
@knative-prow-robot knative-prow-robot added area/autoscale kind/bug Categorizes issue or PR as related to a bug. labels Sep 17, 2018
@tcnghia
Copy link
Contributor

tcnghia commented Sep 18, 2018

/cc @akyyy @josephburnett

@josephburnett
Copy link
Contributor

I think we should move the metrics exporting to another port.

@akyyy
Copy link
Contributor

akyyy commented Sep 18, 2018

/cc @mdemirhan

tanzeeb added a commit to tanzeeb/serving that referenced this issue Sep 24, 2018
@tanzeeb
Use separate port for serving activator metrics (knative#2043)
b190088 
Activator will continue serving data on port 8080, but will now serve
metrics on port 9090.

Fixes knative#2043
@tanzeeb tanzeeb mentioned this issue Sep 24, 2018
Merged
knative-prow-robot pushed a commit that referenced this issue Oct 1, 2018
@tanzeeb @knative-prow-robot
Use separate port for serving activator metrics (#2043) (#2081)
0b9c75b 
Activator will continue serving data on port 8080, but will now serve
metrics on port 9090.

Fixes #2043
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tanzeeb tanzeeb

Labels
area/autoscale kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@tanzeeb @tcnghia @scothis @josephburnett @akyyy @knative-prow-robot