Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebHook does no validation of the revision values #3034

Closed
vagababov opened this issue Jan 29, 2019 · 3 comments · Fixed by #3045
Closed

WebHook does no validation of the revision values #3034

vagababov opened this issue Jan 29, 2019 · 3 comments · Fixed by #3045
Assignees
@vagababov
Labels
area/API API objects and controllers kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Milestone
0.4.x

Comments

@vagababov
Copy link
Contributor

Expected Behavior

you put junk into revisions list your request is rejected.

Actual Behavior

anything is accepted.

Steps to Reproduce the Problem

  1. carve a release more service
  2. set revisions to whatever you want
  3. apply and get the service accepted.

Additional Info

We should verify at least that the revision strings match k8s resource name format (insofar
@knative-prow-robot knative-prow-robot added area/API API objects and controllers kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jan 29, 2019
@vagababov
Copy link
Contributor Author

/milestone Serving 0.4

@knative-prow-robot
Copy link
Contributor

@vagababov: You must be a member of the knative/knative-milestone-maintainers github team to set the milestone.

In response to this:

/milestone Serving 0.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vagababov
Copy link
Contributor Author

/assign

@vagababov vagababov mentioned this issue Jan 31, 2019
Merged
@mattmoor mattmoor added this to the Serving 0.4 milestone Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vagababov vagababov

Labels
area/API API objects and controllers kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
0.4.x
Development

Successfully merging a pull request may close this issue.

Add validation to the revisions provided in the revision list. vagababov/serving
3 participants
@vagababov @mattmoor @knative-prow-robot