Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We need conformance test coverage of generateName #3183

Closed
mattmoor opened this issue Feb 12, 2019 · 1 comment
Closed

We need conformance test coverage of generateName #3183

mattmoor opened this issue Feb 12, 2019 · 1 comment
Assignees
@chizhg
Labels
area/API API objects and controllers area/test-and-release It flags unit/e2e/conformance/perf test issues for product features kind/feature Well-understood/specified features, ready for coding.
Milestone
Serving "v1" (rea...

Comments

@mattmoor
Copy link
Member

In what area(s)?

/area API

/area autoscale
/area build
/area monitoring
/area networking
/area test-and-release

Describe the feature

Folks should be able to use:

metadata:
  generateName: prefix-
spec:
  ...

... to create services against the API with a guaranteed unique name.

We've broken this at least once via overly strong validation.
@mattmoor mattmoor added the kind/feature Well-understood/specified features, ready for coding. label Feb 12, 2019
@knative-prow-robot knative-prow-robot added area/API API objects and controllers area/test-and-release It flags unit/e2e/conformance/perf test issues for product features kind/good-first-issue labels Feb 12, 2019
@mattmoor mattmoor mentioned this issue Feb 12, 2019
Closed
@mattmoor mattmoor changed the title We need test coverage of generateName We need conformance test coverage of generateName Feb 12, 2019
@brandon-mabey
Copy link
Contributor

I can take a look at this.

@brandon-mabey brandon-mabey mentioned this issue Feb 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chizhg chizhg

Labels
area/API API objects and controllers area/test-and-release It flags unit/e2e/conformance/perf test issues for product features kind/feature Well-understood/specified features, ready for coding.
Projects
None yet
Milestone
Serving "v1" (ready for production)
Development

No branches or pull requests
4 participants
@mattmoor @chizhg @knative-prow-robot @brandon-mabey