Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We should validate generateName #3182

Closed
dprotaso opened this issue Feb 12, 2019 · 1 comment · Fixed by #3220
Closed

We should validate generateName #3182

dprotaso opened this issue Feb 12, 2019 · 1 comment · Fixed by #3220
Labels
area/API API objects and controllers kind/feature Well-understood/specified features, ready for coding.
Milestone
0.5.x

Comments

@dprotaso
Copy link
Member

Describe the feature

We've enabled generateName again in this PR #3181

But there's no validation of generatedName. We could ensure generateName with a 'safe' suffix still is a DNS1035 label.
@dprotaso dprotaso added the kind/feature Well-understood/specified features, ready for coding. label Feb 12, 2019
@knative-prow-robot knative-prow-robot added area/API API objects and controllers kind/good-first-issue labels Feb 12, 2019
@dprotaso dprotaso mentioned this issue Feb 12, 2019
Merged
@mattmoor
Copy link
Member

Also related: #3183

@mattmoor mattmoor added this to the Serving 0.5 milestone Feb 12, 2019
@bradhoekstra bradhoekstra mentioned this issue Feb 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/API API objects and controllers kind/feature Well-understood/specified features, ready for coding.
Projects
None yet
Milestone
0.5.x
Development

Successfully merging a pull request may close this issue.

Validate generateName bradhoekstra/serving
3 participants
@dprotaso @mattmoor @knative-prow-robot