Fix validation so users can use generateName #3181
Conversation
knative-prow-robot
added
the
size/M
There was a problem hiding this comment.
@dprotaso: 0 warnings.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
|
/test pull-knative-serving-unit-tests |
|
/test pull-knative-serving-unit-tests |
| msgs := validation.IsDNS1035Label(name) | ||
| if len(msgs) > 0 { | ||
| if name != "" { | ||
| msgs := validation.IsDNS1035Label(name) |
There was a problem hiding this comment.
Does this work? Since generate name most likely is going to have a trailing "-" and DNS1035 label wants a terminating letter, iirc.
In addition, if this name matches the label, the generated name might not (it'll be longer).
There was a problem hiding this comment.
I'm not validating generateName for that reason
There was a problem hiding this comment.
Some API docs say generatedName gets truncated to fit the suffix
There was a problem hiding this comment.
🤦♂️
I misread.
But should we still do some validation thereof? I.e. truncate the "-" and then match?
There was a problem hiding this comment.
But should we still do some validation thereof?
I don't want to go too far down the rabbit hole of figuring out what the API server does exactly. Validating generatedName could be a separate PR.
Trying to unblock #3179 at this point.
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
No description provided.