-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply k8s default values for readiness probe #10700
Apply k8s default values for readiness probe #10700
Conversation
Welcome @shinigambit! It looks like this is your first PR to knative/serving 🎉 |
Hi @shinigambit. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #10700 +/- ##
=======================================
Coverage 88.12% 88.12%
=======================================
Files 186 186
Lines 8898 8903 +5
=======================================
+ Hits 7841 7846 +5
Misses 816 816
Partials 241 241
Continue to review full report at Codecov.
|
/ok-to-test |
/lgtm 🎉 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, shinigambit The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #5732
Adjust k8s readiness probe default values when the periodSeconds property is used