Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop stackdriver exporter support #11659

Merged
merged 2 commits into from
Jul 13, 2021

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented Jul 12, 2021

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 12, 2021
@knative-prow-robot knative-prow-robot added area/API API objects and controllers area/autoscale area/monitoring area/networking size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 12, 2021
@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #11659 (640c559) into main (9c2ec0f) will increase coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11659      +/-   ##
==========================================
+ Coverage   87.86%   87.90%   +0.03%     
==========================================
  Files         190      190              
  Lines        9253     9249       -4     
==========================================
  Hits         8130     8130              
+ Misses        874      872       -2     
+ Partials      249      247       -2     
Impacted Files Coverage Δ
cmd/queue/main.go 0.51% <0.00%> (+<0.01%) ⬆️
pkg/reconciler/revision/resources/queue.go 100.00% <ø> (ø)
pkg/reconciler/configuration/configuration.go 88.46% <0.00%> (+2.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c2ec0f...640c559. Read the comment docs.

@dprotaso
Copy link
Member Author

/assign @evankanderson @skonto

Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit b4b3ad9 into knative:main Jul 13, 2021
@dprotaso dprotaso deleted the no-stack-driver branch July 13, 2021 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/autoscale area/monitoring area/networking cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants