Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retired serving state is not set anywhere #1204

Merged
merged 1 commit into from
Jun 15, 2018
Merged

Retired serving state is not set anywhere #1204

merged 1 commit into from
Jun 15, 2018

Conversation

glyn
Copy link
Contributor

@glyn glyn commented Jun 14, 2018

See issue 1203 and slack.

@google-prow-robot google-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 14, 2018
@glyn
Copy link
Contributor Author

glyn commented Jun 14, 2018

/area autoscale
/kind doc
/assign @josephburnett

josephburnett
josephburnett approved these changes Jun 14, 2018
View reviewed changes
Copy link
Contributor

@josephburnett josephburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-prow-robot google-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2018
@glyn
Copy link
Contributor Author

glyn commented Jun 14, 2018

/assign @vaikas-google

grantr
grantr approved these changes Jun 14, 2018
View reviewed changes
Copy link
Contributor

@grantr grantr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@mattmoor
Copy link
Member

/approve

@google-prow-robot google-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2018
@vaikas
Copy link
Contributor

vaikas commented Jun 15, 2018

/lgtm
/approve

@google-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glyn, grantr, josephburnett, mattmoor, vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-prow-robot google-prow-robot merged commit 29dadab into knative:master Jun 15, 2018
@glyn glyn deleted the unborn-code-warning branch June 27, 2018 10:13
@skyao
Copy link

skyao commented Oct 26, 2018

How about this PR? It's has been 4 month since this PR and related issues.

Will you remove the Retired status?

@markusthoemmes
Copy link
Contributor

@skyao ServingState has been removed in its entirety as of yesterday in #2301. Thanks for mentioning though, I'll go through related comments and see if they're still valid.

nak3 added a commit to nak3/serving that referenced this pull request Aug 24, 2022
@nak3
Bump memory limit in CI template (knative#1204)
facef91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grantr grantr grantr approved these changes

@josephburnett josephburnett josephburnett approved these changes

Assignees

@grantr grantr

@josephburnett josephburnett

@vaikas vaikas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/autoscale kind/doc Something isn't clear lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@glyn @mattmoor @vaikas @google-prow-robot @skyao @markusthoemmes @grantr @josephburnett