Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test coverage of the Service controller code. #1216

Merged
merged 2 commits into from
Jun 15, 2018
Merged

Add test coverage of the Service controller code. #1216

merged 2 commits into from
Jun 15, 2018

Commits on Jun 14, 2018

  1. Add test coverage of the Service controller code. 

    Unlike the other controllers, this follows the pattern of OpenShift's Ingress controller (thanks to @smarterclayton for the pointer). This enables us to have a largely table-driven approach to testing this, which makes adding tests surprisingly easy.
    @mattmoor
    mattmoor committed Jun 14, 2018
    Configuration menu
    Copy the full SHA
    c1aabbb View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2018

  1. Incorporate review feedback. 

    Dropped named returns from listers.go

Rename and document the UpdateFunc helper.
    @mattmoor
    mattmoor committed Jun 15, 2018
    Configuration menu
    Copy the full SHA
    984af5f View commit details
    Browse the repository at this point in the history