Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove freezer code #13830

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Remove freezer code #13830

merged 1 commit into from
Mar 31, 2023

Conversation

psschwei
Copy link
Contributor

The container-freezer is being archived as discussed in knative-extensions/container-freezer#217, so this commit is to remove its code from the serving repo.

Release Note

Container-freezer has been sunset in Knative v1.10.

@psschwei
remove freezer code from queue proxy
8a31cbe 
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
@knative-prow knative-prow bot added area/API API objects and controllers area/autoscale area/networking labels Mar 30, 2023
@knative-prow knative-prow bot requested a review from carlisia March 30, 2023 19:50
@knative-prow knative-prow bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 30, 2023
@knative-prow knative-prow bot requested a review from kauana March 30, 2023 19:50
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2023
@codecov
Copy link

codecov bot commented Mar 30, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: +0.12 🎉

Comparison is base (bb18a82) 86.15% compared to head (8a31cbe) 86.27%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #13830      +/-   ##
==========================================
+ Coverage   86.15%   86.27%   +0.12%     
==========================================
  Files         199      198       -1     
  Lines       14796    14669     -127     
==========================================
- Hits        12747    12656      -91     
+ Misses       1747     1715      -32     
+ Partials      302      298       -4
Impacted Files Coverage Δ
pkg/deployment/config.go 100.00% <ø> (ø)
pkg/queue/sharedmain/handlers.go 0.00% <ø> (ø)
pkg/queue/sharedmain/main.go 0.86% <0.00%> (+0.02%) ⬆️
pkg/reconciler/revision/resources/deploy.go 90.13% <ø> (-0.18%) ⬇️
pkg/reconciler/revision/resources/queue.go 98.22% <ø> (-0.04%) ⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@psschwei
Copy link
Contributor Author

/assign @dprotaso

ReToCode
ReToCode approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold for @dprotaso to review

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 31, 2023
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2023
@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow
Copy link

knative-prow bot commented Mar 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, psschwei, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dprotaso
Copy link
Member

/hold cancel

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 31, 2023
@knative-prow knative-prow bot merged commit 307a7e4 into knative:main Mar 31, 2023
@psschwei psschwei mentioned this pull request Apr 24, 2023
Closed
@psschwei psschwei deleted the drop-freezer branch May 3, 2023 17:54
mgencur added a commit to mgencur/docs that referenced this pull request Aug 13, 2024
@mgencur
Remove cocurrenty-state-endpoint from docs
a28e4f4 
This configuration element was removed as part of
knative/serving#13830
@mgencur mgencur mentioned this pull request Aug 13, 2024
Merged
knative-prow bot pushed a commit to knative/docs that referenced this pull request Sep 16, 2024
@mgencur
Remove cocurrenty-state-endpoint from docs (#6095)
ffaf5bf 
This configuration element was removed as part of
knative/serving#13830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReToCode ReToCode ReToCode approved these changes

@carlisia carlisia Awaiting requested review from carlisia

@kauana kauana Awaiting requested review from kauana

Assignees

@dprotaso dprotaso

@ReToCode ReToCode

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/autoscale area/networking lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@psschwei @dprotaso @ReToCode